Skip to content

London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Hashtag link doesn't work #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delmorallopez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Hashtag link doesn't work #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions front-end/views/hashtag.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ import {createHeading} from "../components/heading.mjs";

// Hashtag view: show all tweets containing this tag

function hashtagView(hashtag) {
async function hashtagView(hashtag) {
destroy();

apiService.getBloomsByHashtag(hashtag);
// prevent infinite loop
if (state.currentHashtag !== `#${hashtag}`) {
await apiService.getBloomsByHashtag(hashtag);
}

renderOne(
state.isLoggedIn,
Expand All @@ -28,22 +31,24 @@ function hashtagView(hashtag) {
document
.querySelector("[data-action='logout']")
?.addEventListener("click", handleLogout);

renderOne(
state.isLoggedIn,
getLoginContainer(),
"login-template",
createLogin
);
document
.querySelector("[data-action='login']")
?.addEventListener("click", handleLogin);
.querySelector('[data-form="login"]')
Copy link
Copy Markdown
Member

@illicitonion illicitonion May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change - in the future, please try to keep changes in separate branches/PRs!

?.addEventListener("submit", handleLogin); // also fix this 👀

renderOne(
state.currentHashtag,
getHeadingContainer(),
"heading-template",
createHeading
);

renderEach(
state.hashtagBlooms || [],
getTimelineContainer(),
Expand Down