Skip to content

Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe#1274

Open
shafiekwalker7861 wants to merge 2 commits into
CodeYourFuture:mainfrom
shafiekwalker7861:wireframe-clean
Open

Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe#1274
shafiekwalker7861 wants to merge 2 commits into
CodeYourFuture:mainfrom
shafiekwalker7861:wireframe-clean

Conversation

@shafiekwalker7861
Copy link
Copy Markdown

Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created a wireframe webpage using semantic HTML and CSS
Added sections explaining wireframes, Git branches, and README files
Styled the page layout and added images
Practiced Git branching and pull request workflow

Questions

This is my first clean pull request workflow, so any feedback on structure or Git usage would be appreciated.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7e46474
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0af4242d2aca0008dff919
😎 Deploy Preview https://deploy-preview-1274--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@shafiekwalker7861 shafiekwalker7861 changed the title Complete wireframe task Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe May 15, 2026
@shafiekwalker7861 shafiekwalker7861 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 15, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 18, 2026
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this page is almost complete. Just one small issue with the footer - see my other comment

Comment thread Wireframe/README.md
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 18, 2026
@LonMcGregor
Copy link
Copy Markdown

This is my first clean pull request workflow, so any feedback on structure or Git usage would be appreciated

I see you only made a single commit once the task was complete. It is OK to make smaller commits incrementally as you make changes instead of one big commit.

@shafiekwalker7861
Copy link
Copy Markdown
Author

This is my first clean pull request workflow, so any feedback on structure or Git usage would be appreciated

I see you only made a single commit once the task was complete. It is OK to make smaller commits incrementally as you make changes instead of one big commit.

Hi LonMcGregor,

Thanks for the feedback. Much appreciated. So what do I do next

@LonMcGregor
Copy link
Copy Markdown

Next steps: If you see my earlier comment, it seems the footer is stuck to the bottom of the page. Try to find a way to make it stick to the bottom of the viewport instead. Then, make a new commit and set the "needs review" label on this PR and I'll take another look.

@LonMcGregor
Copy link
Copy Markdown

Good work. This task is now complete!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants