Skip to content

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 1 | Form Controls #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexandraClincu28 wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −7
Open

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 1 | Form Controls #1285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c1ceb4
complete form
AlexandraClincu28 May 15, 2026
e80f53c
control form
AlexandraClincu28 May 15, 2026
b5f47d9
complete html form
AlexandraClincu28 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,32 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
<label for="name">Name:</label>
<input type="text" id="name" name="name" required minlength="2" />
Comment on lines +16 to +17
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - I do get the right level of strictness here 🎉

<label for="email">Email:</label>
<input type="email" id="email" name="email" required />
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good validation of email by using the type field

<label for="colour">Choose a colour:</label>
<select id="colour" name="colour" required>
<option value="">Select a colour</option>
<option value="black">Black</option>
<option value="white">White</option>
<option value="blue">Blue</option>
</select>
Comment on lines +20 to +26
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to wrap this in a fieldset tag as it can create a bit of structure around a part of the form that is related to one idea, or separate an element out

<label for="size">Choose a size:</label>
<select id="size" name="size" required>
<option value="">Select a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
Comment on lines +27 to +36
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to also wrap this in a fieldset tag

<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Alexandra Clincu </p>
</footer>
</body>
</html>
Loading