Skip to content

London | may-2026-itp | Vitalii Kmit | Sprint 2 | Wireframe#1286

Open
Vitalii-code wants to merge 8 commits into
CodeYourFuture:mainfrom
Vitalii-code:feature/wireframe
Open

London | may-2026-itp | Vitalii Kmit | Sprint 2 | Wireframe#1286
Vitalii-code wants to merge 8 commits into
CodeYourFuture:mainfrom
Vitalii-code:feature/wireframe

Conversation

@Vitalii-code
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Created new articles
  • Filled out the page with information
  • Changed css style

Questions

I'm not sure if the footer should be fixed or not

@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit fe71bb1
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0b527c8ee8e3000807a753
😎 Deploy Preview https://deploy-preview-1286--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Vitalii-code Vitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 18, 2026
Copy link
Copy Markdown

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this task so far. there are some issues with the images, can you take another look?

Comment thread Wireframe/index.html Outdated
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img
src="https://external-content.duckduckgo.com/iu/?u=https%3A%2F%2Falexwlchan.net%2Fimages%2F2021%2Freadmes-for-open-science%2Fslide6.png&f=1&nofb=1&ipt=8d1b781a7151a84e0a93ee0ccf6b730ab844953d13f7201b453c4f13c9ce251e"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at these URLs - I guess you got these from an internet search. They are proxied through duckduckgo, rather than pointing to the real image. These links can break easily, and this image no longer loads. The same is true for the other images here, can you fix that?

Copy link
Copy Markdown
Author

@Vitalii-code Vitalii-code May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I'll fix it when I get home, any other problems that I need to work on?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants