London | 26-ITP-May | Remi M. | Sprint 2 | Wireframe#1306
Open
remimarcelle wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
remimarcelle
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This pull request attempts to complete the requirements for the Wireframe task. The page is built using using semantic HTML tags and includes a header, main section, and footer. Inside the main section are three articles, each featuring a clear heading, a casual and informative summary, and a functional external link.
The footer has been updated with contextual information about the project, including a link to the relevant GitHub issue.
Lighthouse scores at the time of submission were 92 for accessibility
Related issue: remimarcelle/My-Coursework-Planner#7
Questions
There was something I really struggled with and that is making the images fit into the article boxes, and also putting a divider line between the image and article title. I tried so many different ways. So, if you have advice about that that would be great. Also, what do I do with all of these forks? Do I just delete them? Because it's making my Github messy.