London | 26-ITP-May | Rhoda Ajiroba | Sprint 3 | Practice TDD - #1564
Open
codebyra wants to merge 2 commits into
Open
London | 26-ITP-May | Rhoda Ajiroba | Sprint 3 | Practice TDD#1564codebyra wants to merge 2 commits into
codebyra wants to merge 2 commits into
Conversation
codebyra
added
the
Needs Review
Author
|
@LonMcGregor Please review this too |
cjyuan
reviewed
Jul 28, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
There are six files to be updated in the Practice TDD exercise. Did you prepare your work on a separate branch?
cjyuan
added
Reviewed
codebyra
added
the
Needs Review
Author
|
@cjyuan Please review |
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just one comment.
| }); | ||
|
|
||
| // Case 4: All other numbers | ||
| test("should append 'th' for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to. Could you revise the test description to make it more informative?
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint 3 Practice TDD exercise by implementing the required solution and verifying it with the provided tests.