Skip to content
10 changes: 9 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;

for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}

return count;
}

module.exports = countChar;
28 changes: 27 additions & 1 deletion Sprint-3/2-practice-tdd/count.test.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more test cases for multiple occurrences because the example just tested the case of character in the whole string.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const countChar = require("./count");
// Then it should:

// Scenario: Multiple Occurrences
// Given the input string `str`,
// Given the inpunt string `str`,
// And a character `char` that occurs one or more times in `str` (e.g., 'a' in 'aaaaa'),
// When the function is called with these inputs,
// Then it should correctly count occurrences of `char`.
Expand All @@ -19,6 +19,32 @@ test("should count multiple occurrences of a character", () => {

// Scenario: No Occurrences
// Given the input string `str`,

// And a character `char` that does not exist within `str`.
test("should return 0 for an empty string", () => {
const str = "";
const char = "a";

const count = countChar(str, char);

expect(count).toEqual(0);
});

// When the function is called with these inputs,
test("should return 0 when the character does not occur in the string", () => {
const str = "hello";
const char = "z";

const count = countChar(str, char);

expect(count).toEqual(0);
});
// Then it should return 0, indicating that no occurrences of `char` were found.
test("should return 0 when the character does not occur in the string", () => {
const str = "hello";
const char = "z";

const count = countChar(str, char);

expect(count).toEqual(0);
});
Comment on lines +43 to +50

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated test case

14 changes: 12 additions & 2 deletions Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
function getOrdinalNumber(num) {
return "1st";
}
if (num % 10 === 1 && num % 100 !== 11) {
return `${num}st`;
}
if (num % 10 === 2 && num % 100 !== 12) {
return `${num}nd`;
}

if (num % 10 === 3 && num % 100 !== 13) {
return `${num}rd`;
}

return `${num}th`;
}
module.exports = getOrdinalNumber;
23 changes: 21 additions & 2 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const getOrdinalNumber = require("./get-ordinal-number");
// In this week's prep, we started implementing getOrdinalNumber.

// Continue testing and implementing getOrdinalNumber for additional cases.
Expand All @@ -12,9 +11,29 @@ const getOrdinalNumber = require("./get-ordinal-number");

// Case 1: Numbers ending with 1 (but not 11)
// When the number ends with 1, except those ending with 11,
// Then the function should return a string by appending "st" to the number.

const getOrdinalNumber = require("./get-ordinal-number");
// Case 1: Numbers ending with 1 (but not 11)
test("should append 'st' for numbers ending with 1, except those ending with 11", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

// Case 2: Numbers ending with 11
test('should append "th" when the number ends with 11', () => {
expect(getOrdinalNumber(11)).toEqual("11th");
});
// Then the function should return a string by appending "st" to the number.
test('should append "th" when the number ends with 12', () => {
expect(getOrdinalNumber(12)).toEqual("12th");
});
test('should append "th" when the number is 13', () => {
expect(getOrdinalNumber(13)).toEqual("13th");
});
Comment on lines +23 to +33

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that you tested the special cases of 11, 12, and 13. It would be nice if larger values (like 511th or 413th) are tested as well.

test('should append "nd" when the number ends with 2', () => {
expect(getOrdinalNumber(22)).toEqual("22nd");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By referencing to the given example, please add more unique test cases within this test set.

});
test('should append "rd" when the number ends with 3', () => {
expect(getOrdinalNumber(23)).toEqual("23rd");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By referencing to the given example, please add more unique test cases within this test set.

});
16 changes: 12 additions & 4 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
function repeatStr() {
// Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
// The goal is to re-implement that function, not to use it.
return "hellohellohello";
function repeatStr(str, count) {
if (count < 0) {
throw new Error("Count cannot be negative");
}

let result = "";

for (let i = 0; i < count; i++) {
result += str;
}

return result;
}

module.exports = repeatStr;
16 changes: 16 additions & 0 deletions Sprint-3/2-practice-tdd/repeat-str.test.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about empty string (with the same set of counts 3, 1, 0, -1)?

Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,29 @@ test("should repeat the string count times", () => {
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.
test("should repeat the string count times", () => {
const str = "hello";
const count = 1;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("hello");
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.
test("should repeat the string count times", () => {
const str = "hello";
const count = 0;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("");
});

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.

test("should throw an error when count is negative", () => {
expect(() => repeatStr("hello", -1)).toThrow();
});
Loading