Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 3 | Coursework/sprint 3 | Implement and Rewrite Test

[Monsur0001]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Briefly explain your PR.

I cherry-picked the commits to this branch because I earlier did all the task in the sprint 3 branch, instead of creating different branches for the Sprint 3

[jimoholayinka01]

Nice work as you've implemented the three functions. However, there are two small, required fixes so the implementation and tests agree. I recommend fixing those before I approve.

Fix isProperFraction function in 2-is-proper-fraction.js implementation with the code below as negative numerators/denominators are treated as invalid in the current code but the Jest tests expect sign-agnostic behaviour

function isProperFraction(numerator, denominator) {
  if (denominator === 0) return false;
  if (numerator === 0) return true;
  // Normalize denominator to positive so comparison is simple
  if (denominator < 0) {
    numerator = -numerator;
    denominator = -denominator;
  }
  return Math.abs(numerator) < denominator;
}

// The line below allows us to load the isProperFraction function into tests in other files.
module.exports = isProperFraction;

Remove the incorrect example assert in getCardValue implement file

assertEquals(getCardValue("11♥"), 11);