feat(renderer): add viewDiscoveryCaching setting and optimize hot paths#664
Merged
Merged
Conversation
Introduces a dedicated `viewDiscoveryCaching` setting (default true) independent from `viewCaching` so developers can disable path-resolution caching without also disabling view output caching. Hot path improvements: - `cachedExpandPath()` memoizes expandPath() unconditionally — the mapping→absolute-path computation is pure and constant per process - `locateView()` and `locateLayout()` now cache their results in `locateViewCache`/`locateLayoutCache`, benefiting direct callers and module fallback calls that bypass discoverViewPaths() - All expandPath() calls inside locateModuleView/Layout and discoverViewPaths() helper detection route through cachedExpandPath() Adds 7 new test specs covering cache population, always-on expandPathCache behaviour, and correct no-cache behaviour when viewDiscoveryCaching=false. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUinjJLvJod1u9s2e9T6zc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a dedicated
viewDiscoveryCachingsetting (default true)independent from
viewCachingso developers can disable path-resolutioncaching without also disabling view output caching.
Hot path improvements:
cachedExpandPath()memoizes expandPath() unconditionally — themapping→absolute-path computation is pure and constant per process
locateView()andlocateLayout()now cache their results inlocateViewCache/locateLayoutCache, benefiting direct callers andmodule fallback calls that bypass discoverViewPaths()
discoverViewPaths() helper detection route through cachedExpandPath()
Adds 7 new test specs covering cache population, always-on expandPathCache
behaviour, and correct no-cache behaviour when viewDiscoveryCaching=false.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01MUinjJLvJod1u9s2e9T6zc