Skip to content

Show club members from CAS group detail page#12

Merged
Gavin-WangSC merged 2 commits intoComputerization:mainfrom
Gavin-WangSC:main
Apr 14, 2026
Merged

Show club members from CAS group detail page#12
Gavin-WangSC merged 2 commits intoComputerization:mainfrom
Gavin-WangSC:main

Conversation

@Gavin-WangSC
Copy link
Copy Markdown
Contributor

Changes

  • fetch club detail HTML from /Stu/Cas/GroupDetail/{groupId}
  • parse supervisor, president, and member roster from the rendered page
  • retry member detail loading with both C_GroupsID and C_GroupNo
  • surface member loading failures in the UI instead of silently showing an empty list
  • keep club info loading state in sync while membership status and roster load in parallel

@Gavin-WangSC Gavin-WangSC requested a review from at-wr April 14, 2026 15:52
- URL-encode groupId in fetchGroupDetail path
- Move HTML parsing off main thread to avoid UI hitches
- Replace Bool flags with DispatchGroup for parallel load coordination
- Use Swift-native Set dedup instead of NSOrderedSet
- Replace NSError with LocalizedError for parse failures
- Add comment noting intentional TSIMS "memeber" typo in CSS selectors
@Gavin-WangSC Gavin-WangSC merged commit 8b29985 into Computerization:main Apr 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants