repaired victoriametrics backup scripts#200
Closed
jstark1 wants to merge 2 commits intoConSol-Monitoring:labsfrom
Closed
repaired victoriametrics backup scripts#200jstark1 wants to merge 2 commits intoConSol-Monitoring:labsfrom
jstark1 wants to merge 2 commits intoConSol-Monitoring:labsfrom
Conversation
Author
|
Are there any problems with this pull request? |
Contributor
|
i don't think so, it's just the lack of resources to review this PR. |
Author
|
I wanted to clean up my omd patches. What I can say is: vmbackup-cron and vmbackup-cleanup-cron cannot load the configuration files because they have been split up. Furthermore, the jsonpath.py file cannot be found. |
Author
|
I'd like to know if there's been any progress and if there's anything I can do. |
Contributor
|
Thanks, i took your ideas and reworked the scripts a little bit more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files "vmbackup-cron" and "vmbackup-cleanup-cron" uses the old config path to "victoriametrics.conf" which has been replaced by dynamic files in the "config.d" folder.
The jsonpath.py script did also not work for me, so I replaced it with simple grep and tr calls.