Skip to content

Support enable date on non-PV node in alarm config#3809

Open
georgweiss wants to merge 5 commits into
masterfrom
CSSTUDIO-2336
Open

Support enable date on non-PV node in alarm config#3809
georgweiss wants to merge 5 commits into
masterfrom
CSSTUDIO-2336

Conversation

@georgweiss
Copy link
Copy Markdown
Collaborator

@georgweiss georgweiss commented May 27, 2026

This PR implements a feature requested by my users: support enable date on non-PV nodes in alarm config.

I've updated the dialog to support two different UIs, which are now in fxml. The dialog will for a non-PV node looks like:

Screenshot 2026-05-27 at 13 58 50

This is supposed to work as follows:

  • The Enable checkbox will mimic behavior of the enable/disable context menu items for a non-PV node.
  • With a non-null enable date, all PV nodes in the subtree will be updated, regardless of current enable state.
  • If any PV node in the subtree has a non-null enable date, setting a new enable date is not possible as I think this could cause confusion and unexpected behavior. I could be wrong here, though...

Documentation has been updated. It was lacking information on enable date, by the way...

  • Testing:

    • The feature has automated tests
    • [ X] Tests were run
  • Documentation:

    • [ X] The feature is documented
    • [ X] The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants