Skip to content

Conversation

@Mehrn0ush
Copy link
Contributor

This PR adds Argon2 (RFC 9106) to schema/cryptography-defs.json.

Notes on parameter naming vs Issue #756

Issue #756 proposes: Argon2(id|i|d)[-{memoryMiB}][-{iterations}][-{parallelism}].

RFC 9106 defines:

  • m as memory size in kibibytes (KiB),
  • t as number of passes,
  • p as degree of parallelism.

Accordingly, this PR uses:
Argon2(id|i|d)[-{memoryKiB}][-{passes}][-{parallelism}]

If the community prefers the Issue's naming for consistency with existing conventions, I can update the pattern accordingly.

Refs: #756

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner January 25, 2026 20:00
@meghsaha-ibm
Copy link

meghsaha-ibm commented Feb 1, 2026

The primitive for the variant Argon2(id|i|d)[-{memoryKiB}][-{passes}][-{parallelism}] should be kdf. Also, the variable {dkLen} may be considered.

@Mehrn0ush
Copy link
Contributor Author

The primitive for the variant Argon2(id|i|d)[-{memoryKiB}][-{passes}][-{parallelism}] should be kdf. Also, the variable {dkLen} may be considered.

Updated Argon2 variant primitive to kdf and added optional [-{dkLen}] for derived key length, consistent with existing {dkLen} usage in the registry.
Thanks.

Add Argon2 (RFC 9106) to the Cryptography Registry with a parameterized pattern aligned to RFC terminology.

Signed-off-by: Mehrn0ush <[email protected]>
@Mehrn0ush Mehrn0ush force-pushed the feat/crypto-registry-argon2-rfc9106 branch from 95e1727 to 28eacb1 Compare February 2, 2026 11:03
@Mehrn0ush
Copy link
Contributor Author

Added Argon2 to schema/cryptography-defs.schema.json#/definitions/algorithmFamiliesEnum to keep the schema enum aligned with the registry data in schema/cryptography-defs.json.
Without this, BOM 1.7 validation rejects cryptoProperties.algorithmProperties.algorithmFamily: "Argon2" even though Argon2 is present in the registry.
This is a schema-only alignment change; it does not modify the Argon2 registry entry or its variant pattern/primitive semantics.

@Mehrn0ush Mehrn0ush force-pushed the feat/crypto-registry-argon2-rfc9106 branch from 520e69f to 48455b8 Compare February 3, 2026 12:58
@Mehrn0ush
Copy link
Contributor Author

I noticed schema/cryptography-defs.schema.json did not end with a trailing newline in the current base.
My earlier update inadvertently introduced an EOF newline change alongside the intended enum update.
This follow-up commit keeps the file’s original EOF formatting (no trailing newline) and only adds "Argon2" to algorithmFamiliesEnum, so the schema enum remains consistent with cryptography-defs.json without unrelated formatting noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants