[DURACOM-429] simplify truncatable calculation#4949
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 14, 2026
Merged
Conversation
tdonohue
added
bug
1 APPROVAL
lgeggleston
approved these changes
Mar 13, 2026
lgeggleston
left a comment
lgeggleston
left a comment
There was a problem hiding this comment.
✅ Tested with HTML abstract and setup outlined in issue - looks good! Also confirmed that a regular non-HTML abstract is not affected, truncation and Show More works the same on both.
(Note: not a code review, though changes look reasonable at a glance)
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
|
Added testathon label because I believe this might help address an issue reported on T188 in Test Plan. |
tdonohue
approved these changes
Apr 14, 2026
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @FrancescoMolinaro ! Verified this fixes the issues. Code looks good. It also looks (to me) like we may be able to backport this to 9.x and 8.x. So, I'm flagging this for auto-backport
tdonohue
added
port to dspace-8_x
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-8_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #4948
Description
Fixed and simplyfied the truncatable calculation for overflow.
Instructions for Reviewers
Configure some complex html inside a truncatable or follow #4948 for instruction on how to reproduce.
List of changes in this PR:
Refactred method truncateElement in truncatable-part.component.ts
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.