cmake: populate CMAKE_FIND_ROOT_PATH when cross-compiling for a different architecture on Linux#1660
Open
cmake: populate CMAKE_FIND_ROOT_PATH when cross-compiling for a different architecture on Linux#1660
CMAKE_FIND_ROOT_PATH when cross-compiling for a different architecture on Linux#1660Conversation
…rent architecture on Linux
28a26b1 to
c8674cf
Compare
CMAKE_FIND_ROOT_PATH when cross-compiling on LinuxCMAKE_FIND_ROOT_PATH when cross-compiling for a different architecture on Linux
c8674cf to
e5ca00f
Compare
Member
Author
|
I modified a bit the comments to make them more understandable. |
Member
|
Why is it inside |
e5ca00f to
be87af0
Compare
Member
Author
|
Right, it's not needed to be there, I moved it out of that block. |
Member
|
It would be better to avoid setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate
CMAKE_FIND_ROOT_PATHwhen cross-compiling on Linux.Fix:
CMAKE_FIND_ROOTwhen cross-compiling #1659