Fix screenshots with read-only depth buffer#1882
Merged
slipher merged 1 commit intoDaemonEngine:masterfrom Jan 3, 2026
Merged
Conversation
Merged
VReaperV
approved these changes
Jan 2, 2026
Contributor
VReaperV
left a comment
VReaperV
left a comment
There was a problem hiding this comment.
Don't have any affected hardware, but code LGTM.
Member
Author
|
The code path can be tested on any hardware by setting |
Contributor
I see. This fixes the issue on my end. |
When the read-only depth buffer is used (if r_readonlyDepthBuffer is 2, or if it's 1 but the driver lacks certain extensions), the screenshots were done from the 3d rendering buffer instead of the final framebuffer. This caused screenshots to lack tonemapping, color grading and 2D rendering. Fix it by resetting GL_READ_FRAMEBUFFER when taking a screenshot.
slipher
force-pushed
the
screenshots-fix
branch
from
05fe475 to
0c37ff8
Compare
Member
Author
|
I changed it to reset |
Contributor
|
Sure, that works too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the read-only depth buffer is used (if r_readonlyDepthBuffer is 2, or if it's 1 but the driver lacks certain extensions), the screenshots were done from the 3d rendering buffer instead of the final framebuffer. This caused screenshots to lack tonemapping, color grading and 2D rendering. Fix it by resetting GL_READ_FRAMEBUFFER to the default value after it is used.