🐛 [QueryAsync] NoCache flag ignored when doing MultiMap#2112
Draft
Dot-H wants to merge 2 commits intoDapperLib:mainfrom
Draft
🐛 [QueryAsync] NoCache flag ignored when doing MultiMap#2112Dot-H wants to merge 2 commits intoDapperLib:mainfrom
NoCache flag ignored when doing MultiMap#2112Dot-H wants to merge 2 commits intoDapperLib:mainfrom
Conversation
Signed-off-by: Alexandre Bernard <alexandre.bernard@gopigment.com>
Signed-off-by: Alexandre Bernard <alexandre.bernard@gopigment.com>
Dot-H
commented
Sep 17, 2024
Comment on lines
+1013
to
+1014
| await MarsConnection.QueryAsync<int, int, (int, int)>(cmdDef, splitOn: "b", map: (a, b) => (a, b)); | ||
| Assert.Equal(0, SqlMapper.GetCachedSQLCount()); |
Author
There was a problem hiding this comment.
This fails. SqlMapper.GetCachedSQLCount() actually returns 1
Dot-H
commented
Sep 17, 2024
| Assert.Equal(0, before); | ||
|
|
||
| await MarsConnection.QueryAsync<(int, int)>(cmdDef); | ||
| Assert.Equal(0, SqlMapper.GetCachedSQLCount()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the
AssertNoCacheWorksForMultiMaptests shows, when theQueryAsyncmethod is passed asplitOnandmaparguments, theNoCacheflag is actually ignored.The issue seems to come from here