Refactor SMAP parser #10385

jpbempel · 2026-01-15T11:02:13Z

What Does This Do

Simplify code, reduce allocations
remove checked exceptions
use an enum for builders
move packages

Motivation

Reuse for Kotlin classes

Additional Notes

Related to

Note

There is no difference in the SMAP syntax between JSR 45 and Jakarta Debugging Support for Other Languages 2.0. The technical specification (grammar, sections, format) is identical.

Version History

Version	Year	Description
JSR 45	2003	Original specification from Java Community Process
Jakarta 1.0	2019	Re-release of JSR 45 under Eclipse Foundation Specification License (EFSL) for Jakarta EE 8
Jakarta 2.0	2020	Namespace migration from `javax.` to `jakarta.` for Jakarta EE 9

What Changed

Jakarta 1.0: Licensing only (JCP → EFSL). Explicitly documented as "a re-release of JSR 45 under the EFSL".
Jakarta 2.0: Namespace change (javax.* → jakarta.*) as part of Jakarta EE 9.

SMAP Syntax

The SMAP grammar remains unchanged across all versions:

StratumSection, FileSection, LineSection, VendorSection, EmbeddedSourceMaps — all identical.

References

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2026-01-15T11:02:26Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2026-01-15T14:31:23Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/refactor-smap
git_commit_date	1768571431	1768584927
git_commit_sha	`a08b93a`	`616b864`
release_version	1.59.0-SNAPSHOT~a08b93afcb	1.59.0-SNAPSHOT~616b864922

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1768586778	1768586778
ci_job_id	1356602479	1356602479
ci_pipeline_id	91148492	91148492
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-ktszvuqs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-ktszvuqs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090902
Total [baseline] (10.836 s) : 0, 10836055
Agent [candidate] (1.088 s) : 0, 1087579
Total [candidate] (10.815 s) : 0, 10815245
section appsec
Agent [baseline] (1.276 s) : 0, 1275839
Total [baseline] (11.094 s) : 0, 11093752
Agent [candidate] (1.271 s) : 0, 1270796
Total [candidate] (11.087 s) : 0, 11087024
section iast
Agent [baseline] (1.231 s) : 0, 1231027
Total [baseline] (11.177 s) : 0, 11176775
Agent [candidate] (1.235 s) : 0, 1234664
Total [candidate] (11.239 s) : 0, 11239429
section profiling
Agent [baseline] (1.207 s) : 0, 1207161
Total [baseline] (10.932 s) : 0, 10932423
Agent [candidate] (1.223 s) : 0, 1222882
Total [candidate] (11.009 s) : 0, 11008828

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	appsec	1.276 s	184.938 ms (17.0%)
Agent	iast	1.231 s	140.126 ms (12.8%)
Agent	profiling	1.207 s	116.259 ms (10.7%)
Total	tracing	10.836 s	-
Total	appsec	11.094 s	257.696 ms (2.4%)
Total	iast	11.177 s	340.72 ms (3.1%)
Total	profiling	10.932 s	96.368 ms (0.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.271 s	183.217 ms (16.8%)
Agent	iast	1.235 s	147.086 ms (13.5%)
Agent	profiling	1.223 s	135.303 ms (12.4%)
Total	tracing	10.815 s	-
Total	appsec	11.087 s	271.778 ms (2.5%)
Total	iast	11.239 s	424.183 ms (3.9%)
Total	profiling	11.009 s	193.583 ms (1.8%)

gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (655.645 ms) : 0, 655645
BytebuddyAgent [candidate] (653.806 ms) : 0, 653806
GlobalTracer [baseline] (283.411 ms) : 0, 283411
GlobalTracer [candidate] (283.605 ms) : 0, 283605
AppSec [baseline] (32.862 ms) : 0, 32862
AppSec [candidate] (32.485 ms) : 0, 32485
Debugger [baseline] (68.265 ms) : 0, 68265
Debugger [candidate] (67.386 ms) : 0, 67386
Remote Config [baseline] (650.616 µs) : 0, 651
Remote Config [candidate] (626.967 µs) : 0, 627
Telemetry [baseline] (9.119 ms) : 0, 9119
Telemetry [candidate] (9.005 ms) : 0, 9005
Flare Poller [baseline] (3.846 ms) : 0, 3846
Flare Poller [candidate] (3.814 ms) : 0, 3814
section appsec
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (698.098 ms) : 0, 698098
BytebuddyAgent [candidate] (696.006 ms) : 0, 696006
GlobalTracer [baseline] (260.789 ms) : 0, 260789
GlobalTracer [candidate] (259.644 ms) : 0, 259644
AppSec [baseline] (174.28 ms) : 0, 174280
AppSec [candidate] (173.755 ms) : 0, 173755
Debugger [baseline] (67.002 ms) : 0, 67002
Debugger [candidate] (66.268 ms) : 0, 66268
Remote Config [baseline] (767.939 µs) : 0, 768
Remote Config [candidate] (737.571 µs) : 0, 738
Telemetry [baseline] (9.295 ms) : 0, 9295
Telemetry [candidate] (9.304 ms) : 0, 9304
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.658 ms) : 0, 3658
IAST [baseline] (24.973 ms) : 0, 24973
IAST [candidate] (24.66 ms) : 0, 24660
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (795.741 ms) : 0, 795741
BytebuddyAgent [candidate] (797.031 ms) : 0, 797031
GlobalTracer [baseline] (257.926 ms) : 0, 257926
GlobalTracer [candidate] (258.694 ms) : 0, 258694
AppSec [baseline] (34.778 ms) : 0, 34778
AppSec [candidate] (34.025 ms) : 0, 34025
Debugger [baseline] (65.871 ms) : 0, 65871
Debugger [candidate] (67.759 ms) : 0, 67759
Remote Config [baseline] (602.079 µs) : 0, 602
Remote Config [candidate] (595.758 µs) : 0, 596
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.682 ms) : 0, 8682
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (3.62 ms) : 0, 3620
IAST [baseline] (27.215 ms) : 0, 27215
IAST [candidate] (27.422 ms) : 0, 27422
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (703.313 ms) : 0, 703313
BytebuddyAgent [candidate] (712.806 ms) : 0, 712806
GlobalTracer [baseline] (221.531 ms) : 0, 221531
GlobalTracer [candidate] (224.513 ms) : 0, 224513
AppSec [baseline] (32.021 ms) : 0, 32021
AppSec [candidate] (32.73 ms) : 0, 32730
Debugger [baseline] (67.951 ms) : 0, 67951
Debugger [candidate] (68.766 ms) : 0, 68766
Remote Config [baseline] (632.501 µs) : 0, 633
Remote Config [candidate] (636.18 µs) : 0, 636
Telemetry [baseline] (8.94 ms) : 0, 8940
Telemetry [candidate] (9.006 ms) : 0, 9006
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.786 ms) : 0, 3786
ProfilingAgent [baseline] (97.824 ms) : 0, 97824
ProfilingAgent [candidate] (98.574 ms) : 0, 98574
Profiling [baseline] (98.408 ms) : 0, 98408
Profiling [candidate] (99.16 ms) : 0, 99160

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094850
Total [baseline] (8.806 s) : 0, 8806085
Agent [candidate] (1.087 s) : 0, 1086973
Total [candidate] (8.789 s) : 0, 8789180
section iast
Agent [baseline] (1.227 s) : 0, 1226662
Total [baseline] (9.319 s) : 0, 9318826
Agent [candidate] (1.226 s) : 0, 1226436
Total [candidate] (9.355 s) : 0, 9355233

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	iast	1.227 s	131.812 ms (12.0%)
Total	tracing	8.806 s	-
Total	iast	9.319 s	512.741 ms (5.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.087 s	-
Agent	iast	1.226 s	139.463 ms (12.8%)
Total	tracing	8.789 s	-
Total	iast	9.355 s	566.053 ms (6.4%)

gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (658.239 ms) : 0, 658239
BytebuddyAgent [candidate] (653.321 ms) : 0, 653321
GlobalTracer [baseline] (285.316 ms) : 0, 285316
GlobalTracer [candidate] (283.58 ms) : 0, 283580
AppSec [baseline] (32.927 ms) : 0, 32927
AppSec [candidate] (32.694 ms) : 0, 32694
Debugger [baseline] (67.787 ms) : 0, 67787
Debugger [candidate] (67.125 ms) : 0, 67125
Remote Config [baseline] (658.684 µs) : 0, 659
Remote Config [candidate] (637.942 µs) : 0, 638
Telemetry [baseline] (9.033 ms) : 0, 9033
Telemetry [candidate] (9.073 ms) : 0, 9073
Flare Poller [baseline] (3.817 ms) : 0, 3817
Flare Poller [candidate] (3.815 ms) : 0, 3815
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (793.767 ms) : 0, 793767
BytebuddyAgent [candidate] (794.344 ms) : 0, 794344
GlobalTracer [baseline] (257.43 ms) : 0, 257430
GlobalTracer [candidate] (256.811 ms) : 0, 256811
AppSec [baseline] (33.499 ms) : 0, 33499
AppSec [candidate] (32.66 ms) : 0, 32660
Debugger [baseline] (65.483 ms) : 0, 65483
Debugger [candidate] (66.608 ms) : 0, 66608
Remote Config [baseline] (574.511 µs) : 0, 575
Remote Config [candidate] (549.712 µs) : 0, 550
Telemetry [baseline] (8.495 ms) : 0, 8495
Telemetry [candidate] (8.349 ms) : 0, 8349
Flare Poller [baseline] (3.566 ms) : 0, 3566
Flare Poller [candidate] (3.569 ms) : 0, 3569
IAST [baseline] (27.089 ms) : 0, 27089
IAST [candidate] (26.939 ms) : 0, 26939

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/refactor-smap
git_commit_date	1768571431	1768584927
git_commit_sha	`a08b93a`	`616b864`
release_version	1.59.0-SNAPSHOT~a08b93afcb	1.59.0-SNAPSHOT~616b864922

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1768587265	1768587265
ci_job_id	1356602480	1356602480
ci_pipeline_id	91148492	91148492
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-w3w4lkcg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-w3w4lkcg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	worse [+126.747µs; +364.741µs] or [+2.546%; +7.328%]	same [-63.513µs; +510.111µs] or [-0.528%; +4.237%]	unstable [-109.334op/s; +50.646op/s] or [-13.370%; +6.193%]	5.223ms	12.262ms	788.438op/s	4.977ms	12.039ms	817.781op/s
scenario:load:petclinic:profiling:high_load	worse [+507.568µs; +1317.264µs] or [+2.750%; +7.137%]	unsure [+82.778µs; +1416.535µs] or [+0.275%; +4.703%]	unstable [-35.557op/s; +13.744op/s] or [-14.345%; +5.545%]	19.370ms	30.868ms	236.969op/s	18.458ms	30.118ms	247.875op/s
scenario:load:petclinic:appsec:high_load	worse [+0.883ms; +1.748ms] or [+4.890%; +9.685%]	worse [+0.606ms; +1.994ms] or [+2.046%; +6.736%]	unstable [-39.551op/s; +10.176op/s] or [-15.693%; +4.038%]	19.369ms	30.905ms	237.344op/s	18.053ms	29.605ms	252.031op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.317 ms) : 18128, 18506
.   : milestone, 18317,
appsec (18.521 ms) : 18334, 18708
.   : milestone, 18521,
code_origins (17.771 ms) : 17592, 17951
.   : milestone, 17771,
iast (17.816 ms) : 17640, 17993
.   : milestone, 17816,
profiling (18.83 ms) : 18643, 19017
.   : milestone, 18830,
tracing (17.597 ms) : 17426, 17769
.   : milestone, 17597,
section candidate
no_agent (18.409 ms) : 18215, 18602
.   : milestone, 18409,
appsec (19.666 ms) : 19468, 19864
.   : milestone, 19666,
code_origins (17.646 ms) : 17471, 17821
.   : milestone, 17646,
iast (17.635 ms) : 17459, 17811
.   : milestone, 17635,
profiling (19.697 ms) : 19501, 19894
.   : milestone, 19697,
tracing (18.19 ms) : 18009, 18371
.   : milestone, 18190,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.317 ms [18.128 ms, 18.506 ms]	-
appsec	18.521 ms [18.334 ms, 18.708 ms]	204.076 µs (1.1%)
code_origins	17.771 ms [17.592 ms, 17.951 ms]	-545.724 µs (-3.0%)
iast	17.816 ms [17.64 ms, 17.993 ms]	-500.729 µs (-2.7%)
profiling	18.83 ms [18.643 ms, 19.017 ms]	512.632 µs (2.8%)
tracing	17.597 ms [17.426 ms, 17.769 ms]	-719.659 µs (-3.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.409 ms [18.215 ms, 18.602 ms]	-
appsec	19.666 ms [19.468 ms, 19.864 ms]	1.257 ms (6.8%)
code_origins	17.646 ms [17.471 ms, 17.821 ms]	-762.388 µs (-4.1%)
iast	17.635 ms [17.459 ms, 17.811 ms]	-773.447 µs (-4.2%)
profiling	19.697 ms [19.501 ms, 19.894 ms]	1.289 ms (7.0%)
tracing	18.19 ms [18.009 ms, 18.371 ms]	-218.422 µs (-1.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.171 ms) : 1160, 1183
.   : milestone, 1171,
iast (3.206 ms) : 3166, 3246
.   : milestone, 3206,
iast_FULL (5.651 ms) : 5595, 5707
.   : milestone, 5651,
iast_GLOBAL (3.485 ms) : 3438, 3532
.   : milestone, 3485,
profiling (2.104 ms) : 2086, 2122
.   : milestone, 2104,
tracing (1.764 ms) : 1750, 1778
.   : milestone, 1764,
section candidate
no_agent (1.184 ms) : 1173, 1195
.   : milestone, 1184,
iast (3.187 ms) : 3147, 3226
.   : milestone, 3187,
iast_FULL (5.862 ms) : 5804, 5920
.   : milestone, 5862,
iast_GLOBAL (3.564 ms) : 3509, 3620
.   : milestone, 3564,
profiling (1.951 ms) : 1935, 1967
.   : milestone, 1951,
tracing (1.814 ms) : 1798, 1829
.   : milestone, 1814,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.171 ms [1.16 ms, 1.183 ms]	-
iast	3.206 ms [3.166 ms, 3.246 ms]	2.034 ms (173.7%)
iast_FULL	5.651 ms [5.595 ms, 5.707 ms]	4.48 ms (382.4%)
iast_GLOBAL	3.485 ms [3.438 ms, 3.532 ms]	2.314 ms (197.5%)
profiling	2.104 ms [2.086 ms, 2.122 ms]	932.391 µs (79.6%)
tracing	1.764 ms [1.75 ms, 1.778 ms]	592.619 µs (50.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.184 ms [1.173 ms, 1.195 ms]	-
iast	3.187 ms [3.147 ms, 3.226 ms]	2.003 ms (169.2%)
iast_FULL	5.862 ms [5.804 ms, 5.92 ms]	4.679 ms (395.2%)
iast_GLOBAL	3.564 ms [3.509 ms, 3.62 ms]	2.38 ms (201.1%)
profiling	1.951 ms [1.935 ms, 1.967 ms]	767.264 µs (64.8%)
tracing	1.814 ms [1.798 ms, 1.829 ms]	629.765 µs (53.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/refactor-smap
git_commit_date	1768571431	1768584927
git_commit_sha	`a08b93a`	`616b864`
release_version	1.59.0-SNAPSHOT~a08b93afcb	1.59.0-SNAPSHOT~616b864922

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1768586988	1768586988
ci_job_id	1356602481	1356602481
ci_pipeline_id	91148492	91148492
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-tb8bxovc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-tb8bxovc 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
appsec (14.632 s) : 14632000, 14632000
.   : milestone, 14632000,
iast (18.174 s) : 18174000, 18174000
.   : milestone, 18174000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
.   : milestone, 17902000,
profiling (14.861 s) : 14861000, 14861000
.   : milestone, 14861000,
tracing (14.636 s) : 14636000, 14636000
.   : milestone, 14636000,
section candidate
no_agent (15.168 s) : 15168000, 15168000
.   : milestone, 15168000,
appsec (14.413 s) : 14413000, 14413000
.   : milestone, 14413000,
iast (18.173 s) : 18173000, 18173000
.   : milestone, 18173000,
iast_GLOBAL (17.621 s) : 17621000, 17621000
.   : milestone, 17621000,
profiling (15.341 s) : 15341000, 15341000
.   : milestone, 15341000,
tracing (14.881 s) : 14881000, 14881000
.   : milestone, 14881000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.072 s [15.072 s, 15.072 s]	-
appsec	14.632 s [14.632 s, 14.632 s]	-440.0 ms (-2.9%)
iast	18.174 s [18.174 s, 18.174 s]	3.102 s (20.6%)
iast_GLOBAL	17.902 s [17.902 s, 17.902 s]	2.83 s (18.8%)
profiling	14.861 s [14.861 s, 14.861 s]	-211.0 ms (-1.4%)
tracing	14.636 s [14.636 s, 14.636 s]	-436.0 ms (-2.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.168 s [15.168 s, 15.168 s]	-
appsec	14.413 s [14.413 s, 14.413 s]	-755.0 ms (-5.0%)
iast	18.173 s [18.173 s, 18.173 s]	3.005 s (19.8%)
iast_GLOBAL	17.621 s [17.621 s, 17.621 s]	2.453 s (16.2%)
profiling	15.341 s [15.341 s, 15.341 s]	173.0 ms (1.1%)
tracing	14.881 s [14.881 s, 14.881 s]	-287.0 ms (-1.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~616b864922, baseline=1.59.0-SNAPSHOT~a08b93afcb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.659 ms) : 3443, 3874
.   : milestone, 3659,
iast (2.201 ms) : 2136, 2265
.   : milestone, 2201,
iast_GLOBAL (2.255 ms) : 2189, 2320
.   : milestone, 2255,
profiling (2.06 ms) : 2007, 2113
.   : milestone, 2060,
tracing (2.046 ms) : 1995, 2097
.   : milestone, 2046,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (3.716 ms) : 3498, 3935
.   : milestone, 3716,
iast (2.208 ms) : 2143, 2273
.   : milestone, 2208,
iast_GLOBAL (2.245 ms) : 2180, 2310
.   : milestone, 2245,
profiling (2.087 ms) : 2033, 2141
.   : milestone, 2087,
tracing (2.031 ms) : 1980, 2082
.   : milestone, 2031,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.659 ms [3.443 ms, 3.874 ms]	2.186 ms (148.4%)
iast	2.201 ms [2.136 ms, 2.265 ms]	728.072 µs (49.4%)
iast_GLOBAL	2.255 ms [2.189 ms, 2.32 ms]	782.032 µs (53.1%)
profiling	2.06 ms [2.007 ms, 2.113 ms]	587.513 µs (39.9%)
tracing	2.046 ms [1.995 ms, 2.097 ms]	573.579 µs (38.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.454 ms, 1.477 ms]	-
appsec	3.716 ms [3.498 ms, 3.935 ms]	2.25 ms (153.5%)
iast	2.208 ms [2.143 ms, 2.273 ms]	742.128 µs (50.6%)
iast_GLOBAL	2.245 ms [2.18 ms, 2.31 ms]	779.172 µs (53.2%)
profiling	2.087 ms [2.033 ms, 2.141 ms]	621.007 µs (42.4%)
tracing	2.031 ms [1.98 ms, 2.082 ms]	565.084 µs (38.6%)

bric3

Cool !

...va-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/StratumManager.java

bric3 · 2026-01-15T14:58:14Z

> Task :dd-java-agent:instrumentation:datadog:asm:iast-instrumenter:test
SourceMapperImplTest > test getFileAndLine FAILED
    java.lang.ClassCastException at SourceMapperImplTest.groovy:40

Groovy...

bric3 · 2026-01-16T09:28:07Z

...va-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/StratumManager.java

+  public static StratumManager init(int sourceMappingLimit, IntConsumer limitReachedCallback) {
+    INSTANCE = new StratumManager(sourceMappingLimit, limitReachedCallback);
+    return INSTANCE;
+  }


note: This is weird, but as discussed IRL, this is enough for now.

jandro996 · 2026-01-16T11:16:44Z

...ava-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/parser/Parser.java

+import java.util.regex.Pattern;
+
+public class Parser {
+  private static final Pattern END_OF_LINE_PATTERN = Pattern.compile("\n");


Just wondering if this works for all OS as they use different line ending (CR, LF y CRLF)

Maybe we can use Pattern.compile("\\r?\\n|\\r") or something similar

good catch!
I have modified the pattern

jandro996

LGtM! just a comment in the Parser

Simplify code, reduce allocations remove checked exceptions use an enum for builders

Fix tests

jpbempel requested review from a team as code owners January 15, 2026 11:02

jpbempel requested review from claponcet and manuel-alvarez-alvarez January 15, 2026 11:02

jpbempel added comp: tooling Build & Tooling type: refactoring tag: no release notes Changes to exclude from release notes labels Jan 15, 2026

bric3 reviewed Jan 15, 2026

View reviewed changes

bric3 approved these changes Jan 16, 2026

View reviewed changes

jandro996 reviewed Jan 16, 2026

View reviewed changes

jandro996 approved these changes Jan 16, 2026

View reviewed changes

jpbempel added 9 commits January 16, 2026 18:35

Refactor SMAP parser

99544bf

Simplify code, reduce allocations remove checked exceptions use an enum for builders

move packages

75f1909

fix compilation

06844c8

Remove dependency to IAST with StratumManager

7e3a070

Fix tests

remove iast metric from StratumManager

874f8b9

fix tests

25de631

fix tests

541f54f

fix codenarc

eda9e5b

fix the pattern for splitting lines

616b864

jpbempel force-pushed the jpbempel/refactor-smap branch from 2db0877 to 616b864 Compare January 16, 2026 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor SMAP parser #10385

Refactor SMAP parser #10385

Uh oh!

jpbempel commented Jan 15, 2026 •

edited by bric3

Loading

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

bric3 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bric3 commented Jan 15, 2026

Uh oh!

bric3 Jan 16, 2026

Uh oh!

jandro996 Jan 16, 2026

Uh oh!

jpbempel Jan 16, 2026

Uh oh!

jandro996 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Refactor SMAP parser #10385

Are you sure you want to change the base?

Refactor SMAP parser #10385

Uh oh!

Conversation

jpbempel commented Jan 15, 2026 • edited by bric3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Version History

What Changed

SMAP Syntax

References

Contributor Checklist

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bric3 commented Jan 15, 2026

Uh oh!

bric3 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jandro996 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jpbempel commented Jan 15, 2026 •

edited by bric3

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading

pr-commenter bot commented Jan 15, 2026 •

edited

Loading