Skip to content

Conversation

@mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Jan 15, 2026

What Does This Do

Currently, if async calls done in the GraphQL result in exceptions, the integration will return the exception wrapped in a CompletionException. This PR instruments the DataFetcherExceptionHandlerParameters.getException method to unwrap the exception of any CompletionException before sending the exception to GraphQL's DataFetcherExceptionHandler.

Note that GraphQL's basic implementation of their DataFetcherExceptionHandler already unwraps one layer of CompletionException.

Motivation

Escalation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/graphql_exception_handler
git_commit_date 1768492445 1768515016
git_commit_sha fae5bf3 557d566
release_version 1.59.0-SNAPSHOT~fae5bf3ff7 1.59.0-SNAPSHOT~557d566fa8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1768517003 1768517003
ci_job_id 1354452981 1354452981
ci_pipeline_id 90998930 90998930
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-8vowtl5w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-8vowtl5w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.128 s) : 0, 1127549
Total [baseline] (11.221 s) : 0, 11221098
Agent [candidate] (1.128 s) : 0, 1127785
Total [candidate] (11.185 s) : 0, 11184872
section appsec
Agent [baseline] (1.311 s) : 0, 1311444
Total [baseline] (11.495 s) : 0, 11494583
Agent [candidate] (1.304 s) : 0, 1304136
Total [candidate] (11.534 s) : 0, 11533755
section iast
Agent [baseline] (1.261 s) : 0, 1261127
Total [baseline] (11.463 s) : 0, 11463117
Agent [candidate] (1.262 s) : 0, 1262233
Total [candidate] (11.5 s) : 0, 11500437
section profiling
Agent [baseline] (1.247 s) : 0, 1246912
Total [baseline] (11.175 s) : 0, 11175388
Agent [candidate] (1.24 s) : 0, 1240048
Total [candidate] (11.186 s) : 0, 11186191
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.128 s -
Agent appsec 1.311 s 183.895 ms (16.3%)
Agent iast 1.261 s 133.578 ms (11.8%)
Agent profiling 1.247 s 119.363 ms (10.6%)
Total tracing 11.221 s -
Total appsec 11.495 s 273.484 ms (2.4%)
Total iast 11.463 s 242.018 ms (2.2%)
Total profiling 11.175 s -45.71 ms (-0.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.128 s -
Agent appsec 1.304 s 176.351 ms (15.6%)
Agent iast 1.262 s 134.448 ms (11.9%)
Agent profiling 1.24 s 112.263 ms (10.0%)
Total tracing 11.185 s -
Total appsec 11.534 s 348.883 ms (3.1%)
Total iast 11.5 s 315.565 ms (2.8%)
Total profiling 11.186 s 1.318 ms (0.0%)
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.268 ms) : 0, 1268
crashtracking [candidate] (1.265 ms) : 0, 1265
BytebuddyAgent [baseline] (675.222 ms) : 0, 675222
BytebuddyAgent [candidate] (676.234 ms) : 0, 676234
GlobalTracer [baseline] (294.955 ms) : 0, 294955
GlobalTracer [candidate] (294.421 ms) : 0, 294421
AppSec [baseline] (33.988 ms) : 0, 33988
AppSec [candidate] (34.031 ms) : 0, 34031
Debugger [baseline] (70.671 ms) : 0, 70671
Debugger [candidate] (71.119 ms) : 0, 71119
Remote Config [baseline] (695.071 µs) : 0, 695
Remote Config [candidate] (696.785 µs) : 0, 697
Telemetry [baseline] (9.368 ms) : 0, 9368
Telemetry [candidate] (9.423 ms) : 0, 9423
Flare Poller [baseline] (4.847 ms) : 0, 4847
Flare Poller [candidate] (3.912 ms) : 0, 3912
section appsec
crashtracking [baseline] (1.25 ms) : 0, 1250
crashtracking [candidate] (1.253 ms) : 0, 1253
BytebuddyAgent [baseline] (713.342 ms) : 0, 713342
BytebuddyAgent [candidate] (710.499 ms) : 0, 710499
GlobalTracer [baseline] (269.82 ms) : 0, 269820
GlobalTracer [candidate] (268.543 ms) : 0, 268543
IAST [baseline] (26.119 ms) : 0, 26119
IAST [candidate] (25.773 ms) : 0, 25773
AppSec [baseline] (178.383 ms) : 0, 178383
AppSec [candidate] (178.707 ms) : 0, 178707
Debugger [baseline] (71.484 ms) : 0, 71484
Debugger [candidate] (68.522 ms) : 0, 68522
Remote Config [baseline] (858.821 µs) : 0, 859
Remote Config [candidate] (846.269 µs) : 0, 846
Telemetry [baseline] (9.792 ms) : 0, 9792
Telemetry [candidate] (9.829 ms) : 0, 9829
Flare Poller [baseline] (3.959 ms) : 0, 3959
Flare Poller [candidate] (3.951 ms) : 0, 3951
section iast
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (810.755 ms) : 0, 810755
BytebuddyAgent [candidate] (812.789 ms) : 0, 812789
GlobalTracer [baseline] (266.708 ms) : 0, 266708
GlobalTracer [candidate] (266.187 ms) : 0, 266187
IAST [baseline] (28.086 ms) : 0, 28086
IAST [candidate] (28.299 ms) : 0, 28299
AppSec [baseline] (35.352 ms) : 0, 35352
AppSec [candidate] (34.066 ms) : 0, 34066
Debugger [baseline] (69.477 ms) : 0, 69477
Debugger [candidate] (70.429 ms) : 0, 70429
Remote Config [baseline] (612.446 µs) : 0, 612
Remote Config [candidate] (629.239 µs) : 0, 629
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.777 ms) : 0, 8777
Flare Poller [baseline] (3.731 ms) : 0, 3731
Flare Poller [candidate] (3.669 ms) : 0, 3669
section profiling
crashtracking [baseline] (1.278 ms) : 0, 1278
crashtracking [candidate] (1.263 ms) : 0, 1263
BytebuddyAgent [baseline] (724.704 ms) : 0, 724704
BytebuddyAgent [candidate] (721.011 ms) : 0, 721011
GlobalTracer [baseline] (231.666 ms) : 0, 231666
GlobalTracer [candidate] (231.15 ms) : 0, 231150
AppSec [baseline] (33.568 ms) : 0, 33568
AppSec [candidate] (33.374 ms) : 0, 33374
Debugger [baseline] (71.564 ms) : 0, 71564
Debugger [candidate] (70.884 ms) : 0, 70884
Remote Config [baseline] (648.847 µs) : 0, 649
Remote Config [candidate] (699.599 µs) : 0, 700
Telemetry [baseline] (9.474 ms) : 0, 9474
Telemetry [candidate] (9.545 ms) : 0, 9545
Flare Poller [baseline] (3.901 ms) : 0, 3901
Flare Poller [candidate] (3.898 ms) : 0, 3898
ProfilingAgent [baseline] (98.725 ms) : 0, 98725
ProfilingAgent [candidate] (97.173 ms) : 0, 97173
Profiling [baseline] (99.323 ms) : 0, 99323
Profiling [candidate] (97.77 ms) : 0, 97770
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.116 s) : 0, 1115506
Total [baseline] (9.385 s) : 0, 9384988
Agent [candidate] (1.117 s) : 0, 1116892
Total [candidate] (9.393 s) : 0, 9393003
section iast
Agent [baseline] (1.26 s) : 0, 1260161
Total [baseline] (9.977 s) : 0, 9976620
Agent [candidate] (1.259 s) : 0, 1259061
Total [candidate] (9.993 s) : 0, 9992712
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.116 s -
Agent iast 1.26 s 144.655 ms (13.0%)
Total tracing 9.385 s -
Total iast 9.977 s 591.632 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.117 s -
Agent iast 1.259 s 142.169 ms (12.7%)
Total tracing 9.393 s -
Total iast 9.993 s 599.709 ms (6.4%)
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.271 ms) : 0, 1271
crashtracking [candidate] (1.242 ms) : 0, 1242
BytebuddyAgent [baseline] (668.142 ms) : 0, 668142
BytebuddyAgent [candidate] (670.373 ms) : 0, 670373
GlobalTracer [baseline] (292.209 ms) : 0, 292209
GlobalTracer [candidate] (291.917 ms) : 0, 291917
AppSec [baseline] (33.738 ms) : 0, 33738
AppSec [candidate] (33.536 ms) : 0, 33536
Debugger [baseline] (70.061 ms) : 0, 70061
Debugger [candidate] (69.673 ms) : 0, 69673
Remote Config [baseline] (687.96 µs) : 0, 688
Remote Config [candidate] (712.26 µs) : 0, 712
Telemetry [baseline] (9.275 ms) : 0, 9275
Telemetry [candidate] (9.322 ms) : 0, 9322
Flare Poller [baseline] (3.85 ms) : 0, 3850
Flare Poller [candidate] (3.904 ms) : 0, 3904
section iast
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.253 ms) : 0, 1253
BytebuddyAgent [baseline] (812.08 ms) : 0, 812080
BytebuddyAgent [candidate] (811.781 ms) : 0, 811781
GlobalTracer [baseline] (266.465 ms) : 0, 266465
GlobalTracer [candidate] (266.238 ms) : 0, 266238
IAST [baseline] (28.048 ms) : 0, 28048
IAST [candidate] (28.038 ms) : 0, 28038
AppSec [baseline] (37.242 ms) : 0, 37242
AppSec [candidate] (33.183 ms) : 0, 33183
Debugger [baseline] (65.924 ms) : 0, 65924
Debugger [candidate] (69.426 ms) : 0, 69426
Remote Config [baseline] (604.972 µs) : 0, 605
Remote Config [candidate] (620.986 µs) : 0, 621
Telemetry [baseline] (8.811 ms) : 0, 8811
Telemetry [candidate] (8.784 ms) : 0, 8784
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.689 ms) : 0, 3689
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/graphql_exception_handler
git_commit_date 1768492445 1768515016
git_commit_sha fae5bf3 557d566
release_version 1.59.0-SNAPSHOT~fae5bf3ff7 1.59.0-SNAPSHOT~557d566fa8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1768517577 1768517577
ci_job_id 1354452984 1354452984
ci_pipeline_id 90998930 90998930
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-2oxhncq9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-2oxhncq9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast:high_load worse
[+127.963µs; +242.266µs] or [+4.994%; +9.455%]
worse
[+193.227µs; +600.195µs] or [+2.564%; +7.964%]
unstable
[-206.849op/s; +66.786op/s] or [-14.989%; +4.840%]
2.747ms 7.933ms 1309.969op/s 2.562ms 7.536ms 1380.000op/s
scenario:load:petclinic:profiling:high_load better
[-2.370ms; -1.858ms] or [-11.300%; -8.859%]
better
[-2.741ms; -1.534ms] or [-8.441%; -4.724%]
unstable
[-2.756op/s; +47.631op/s] or [-1.248%; +21.562%]
18.860ms 30.331ms 243.344op/s 20.974ms 32.468ms 220.906op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.671 ms) : 19468, 19874
.   : milestone, 19671,
appsec (19.131 ms) : 18937, 19324
.   : milestone, 19131,
code_origins (18.273 ms) : 18091, 18455
.   : milestone, 18273,
iast (18.024 ms) : 17842, 18206
.   : milestone, 18024,
profiling (21.137 ms) : 20930, 21344
.   : milestone, 21137,
tracing (18.355 ms) : 18170, 18539
.   : milestone, 18355,
section candidate
no_agent (19.768 ms) : 19566, 19971
.   : milestone, 19768,
appsec (19.119 ms) : 18924, 19314
.   : milestone, 19119,
code_origins (18.396 ms) : 18208, 18583
.   : milestone, 18396,
iast (17.985 ms) : 17807, 18164
.   : milestone, 17985,
profiling (19.183 ms) : 18992, 19374
.   : milestone, 19183,
tracing (18.559 ms) : 18369, 18748
.   : milestone, 18559,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.671 ms [19.468 ms, 19.874 ms] -
appsec 19.131 ms [18.937 ms, 19.324 ms] -540.256 µs (-2.7%)
code_origins 18.273 ms [18.091 ms, 18.455 ms] -1.398 ms (-7.1%)
iast 18.024 ms [17.842 ms, 18.206 ms] -1.647 ms (-8.4%)
profiling 21.137 ms [20.93 ms, 21.344 ms] 1.466 ms (7.5%)
tracing 18.355 ms [18.17 ms, 18.539 ms] -1.317 ms (-6.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.768 ms [19.566 ms, 19.971 ms] -
appsec 19.119 ms [18.924 ms, 19.314 ms] -649.12 µs (-3.3%)
code_origins 18.396 ms [18.208 ms, 18.583 ms] -1.373 ms (-6.9%)
iast 17.985 ms [17.807 ms, 18.164 ms] -1.783 ms (-9.0%)
profiling 19.183 ms [18.992 ms, 19.374 ms] -584.935 µs (-3.0%)
tracing 18.559 ms [18.369 ms, 18.748 ms] -1.209 ms (-6.1%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.299 ms) : 1286, 1312
.   : milestone, 1299,
iast (3.317 ms) : 3269, 3365
.   : milestone, 3317,
iast_FULL (6.446 ms) : 6378, 6514
.   : milestone, 6446,
iast_GLOBAL (3.873 ms) : 3803, 3943
.   : milestone, 3873,
profiling (2.319 ms) : 2298, 2340
.   : milestone, 2319,
tracing (2.012 ms) : 1994, 2029
.   : milestone, 2012,
section candidate
no_agent (1.317 ms) : 1305, 1330
.   : milestone, 1317,
iast (3.497 ms) : 3448, 3546
.   : milestone, 3497,
iast_FULL (6.487 ms) : 6418, 6557
.   : milestone, 6487,
iast_GLOBAL (3.772 ms) : 3711, 3832
.   : milestone, 3772,
profiling (2.415 ms) : 2392, 2438
.   : milestone, 2415,
tracing (1.912 ms) : 1896, 1928
.   : milestone, 1912,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.299 ms [1.286 ms, 1.312 ms] -
iast 3.317 ms [3.269 ms, 3.365 ms] 2.018 ms (155.4%)
iast_FULL 6.446 ms [6.378 ms, 6.514 ms] 5.147 ms (396.2%)
iast_GLOBAL 3.873 ms [3.803 ms, 3.943 ms] 2.574 ms (198.1%)
profiling 2.319 ms [2.298 ms, 2.34 ms] 1.02 ms (78.5%)
tracing 2.012 ms [1.994 ms, 2.029 ms] 712.539 µs (54.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.317 ms [1.305 ms, 1.33 ms] -
iast 3.497 ms [3.448 ms, 3.546 ms] 2.18 ms (165.5%)
iast_FULL 6.487 ms [6.418 ms, 6.557 ms] 5.17 ms (392.5%)
iast_GLOBAL 3.772 ms [3.711 ms, 3.832 ms] 2.454 ms (186.3%)
profiling 2.415 ms [2.392 ms, 2.438 ms] 1.098 ms (83.3%)
tracing 1.912 ms [1.896 ms, 1.928 ms] 594.716 µs (45.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/graphql_exception_handler
git_commit_date 1768492445 1768515016
git_commit_sha fae5bf3 557d566
release_version 1.59.0-SNAPSHOT~fae5bf3ff7 1.59.0-SNAPSHOT~557d566fa8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1768517385 1768517385
ci_job_id 1354452986 1354452986
ci_pipeline_id 90998930 90998930
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-3grsq9gw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-3grsq9gw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.486 ms) : 1475, 1498
.   : milestone, 1486,
appsec (2.802 ms) : 2717, 2887
.   : milestone, 2802,
iast (2.585 ms) : 2482, 2687
.   : milestone, 2585,
iast_GLOBAL (2.631 ms) : 2528, 2734
.   : milestone, 2631,
profiling (2.406 ms) : 2319, 2492
.   : milestone, 2406,
tracing (2.382 ms) : 2298, 2467
.   : milestone, 2382,
section candidate
no_agent (1.485 ms) : 1473, 1496
.   : milestone, 1485,
appsec (2.806 ms) : 2720, 2891
.   : milestone, 2806,
iast (2.595 ms) : 2492, 2699
.   : milestone, 2595,
iast_GLOBAL (2.627 ms) : 2524, 2731
.   : milestone, 2627,
profiling (2.441 ms) : 2352, 2530
.   : milestone, 2441,
tracing (2.364 ms) : 2281, 2448
.   : milestone, 2364,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.475 ms, 1.498 ms] -
appsec 2.802 ms [2.717 ms, 2.887 ms] 1.316 ms (88.5%)
iast 2.585 ms [2.482 ms, 2.687 ms] 1.098 ms (73.9%)
iast_GLOBAL 2.631 ms [2.528 ms, 2.734 ms] 1.145 ms (77.0%)
profiling 2.406 ms [2.319 ms, 2.492 ms] 919.156 µs (61.8%)
tracing 2.382 ms [2.298 ms, 2.467 ms] 895.831 µs (60.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.473 ms, 1.496 ms] -
appsec 2.806 ms [2.72 ms, 2.891 ms] 1.321 ms (89.0%)
iast 2.595 ms [2.492 ms, 2.699 ms] 1.111 ms (74.8%)
iast_GLOBAL 2.627 ms [2.524 ms, 2.731 ms] 1.143 ms (77.0%)
profiling 2.441 ms [2.352 ms, 2.53 ms] 956.468 µs (64.4%)
tracing 2.364 ms [2.281 ms, 2.448 ms] 879.657 µs (59.3%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~557d566fa8, baseline=1.59.0-SNAPSHOT~fae5bf3ff7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
appsec (14.374 s) : 14374000, 14374000
.   : milestone, 14374000,
iast (17.535 s) : 17535000, 17535000
.   : milestone, 17535000,
iast_GLOBAL (17.11 s) : 17110000, 17110000
.   : milestone, 17110000,
profiling (14.609 s) : 14609000, 14609000
.   : milestone, 14609000,
tracing (14.125 s) : 14125000, 14125000
.   : milestone, 14125000,
section candidate
no_agent (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
appsec (14.074 s) : 14074000, 14074000
.   : milestone, 14074000,
iast (17.683 s) : 17683000, 17683000
.   : milestone, 17683000,
iast_GLOBAL (17.491 s) : 17491000, 17491000
.   : milestone, 17491000,
profiling (14.157 s) : 14157000, 14157000
.   : milestone, 14157000,
tracing (14.219 s) : 14219000, 14219000
.   : milestone, 14219000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.117 s [15.117 s, 15.117 s] -
appsec 14.374 s [14.374 s, 14.374 s] -743.0 ms (-4.9%)
iast 17.535 s [17.535 s, 17.535 s] 2.418 s (16.0%)
iast_GLOBAL 17.11 s [17.11 s, 17.11 s] 1.993 s (13.2%)
profiling 14.609 s [14.609 s, 14.609 s] -508.0 ms (-3.4%)
tracing 14.125 s [14.125 s, 14.125 s] -992.0 ms (-6.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.999 s [14.999 s, 14.999 s] -
appsec 14.074 s [14.074 s, 14.074 s] -925.0 ms (-6.2%)
iast 17.683 s [17.683 s, 17.683 s] 2.684 s (17.9%)
iast_GLOBAL 17.491 s [17.491 s, 17.491 s] 2.492 s (16.6%)
profiling 14.157 s [14.157 s, 14.157 s] -842.0 ms (-5.6%)
tracing 14.219 s [14.219 s, 14.219 s] -780.0 ms (-5.2%)

@mhlidd mhlidd marked this pull request as ready for review January 16, 2026 19:00
@mhlidd mhlidd requested a review from a team as a code owner January 16, 2026 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Copy link
Contributor

@jordan-wong jordan-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would want to make sure there are no issues with unwrapping in all possible cases. Perhaps keeping the original exception would be helpful for keeping context of where the original exception occurred in the stack trace, because unwrapping will only keep the inner exception's stack trace. Otherwise if this is not a concern, then LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants