Skip to content

Remove remaining Gradle buildscript blocks#11975

Open
bric3 wants to merge 2 commits into
masterfrom
bdu/remove-the-last-buildscripts
Open

Remove remaining Gradle buildscript blocks#11975
bric3 wants to merge 2 commits into
masterfrom
bdu/remove-the-last-buildscripts

Conversation

@bric3

@bric3 bric3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Removes the two remaining Gradle buildscript blocks.

DataNucleus now loads its enhancer from a dedicated lazy project configuration instead of the script classpath (which is now usually a bad practice). The shared Java build scripts already configure repositories for normal project dependencies.

The forbidden-apis script now relies on the plugin version declared by the root build instead of carrying its own script classpath and repository setup.

Motivation

This keeps plugin and dependency resolution in the normal Gradle model and removes duplicated repository/classpath configuration from script plugins.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

bric3 added 2 commits July 16, 2026 18:44
Load the DataNucleus enhancer from a dedicated project configuration
instead of the script classpath. This keeps the enhancer dependencies
in the normal dependency model and resolves them only when the enhance
task runs.

Also, this project already gets repository setup from the shared Java
build scripts.
The root build already declares the forbidden-apis plugin version.
Reuse that plugin declaration from the shared script instead of
carrying a second script-level classpath and repository setup.
@bric3
bric3 requested review from a team as code owners July 16, 2026 16:44
@bric3
bric3 requested review from ygree and removed request for a team July 16, 2026 16:44
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 16, 2026

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

This PR safely removes two Gradle buildscript blocks by consolidating plugin and dependency resolution into standard Gradle mechanisms (root plugin declaration and lazy configurations). The removed script classpath complexity is replaced with simpler, more maintainable Gradle patterns. No behavioral regressions identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 275ddc0 · What is Autotest? · Any feedback? Reach out in #autotest

@bric3
bric3 requested a review from sarahchen6 July 16, 2026 16:54
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.16% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 275ddc0 | Docs | Datadog PR Page | Give us feedback!

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! just curious - how'd you know we can do this?

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.05 s 13.93 s [+0.2%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.94 s 13.01 s [-1.3%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.95 s 16.76 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.91 s 17.02 s [-1.5%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.63 s 16.79 s [-2.0%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.96 s 16.26 s [-0.3%; +8.9%] (no difference)
startup:petclinic:tracing:Agent 16.17 s 15.69 s [-1.3%; +7.3%] (no difference)

Commit: 275ddc0e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3

bric3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 16, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-16 17:15:36 UTC ℹ️ Start processing command /merge


2026-07-16 17:15:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-16 21:39:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants