Skip to content

Incorporate the sidecar communication protocol changes from libdatadog#3695

Open
bwoebi wants to merge 28 commits intomasterfrom
bob/libdd-update
Open

Incorporate the sidecar communication protocol changes from libdatadog#3695
bwoebi wants to merge 28 commits intomasterfrom
bob/libdd-update

Conversation

@bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 7, 2026

And updating tests with it.

@bwoebi bwoebi requested review from a team as code owners March 7, 2026 14:11
@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 7, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 15 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:60
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69c065a20000000005c623179f5a7b71
tid: 69c065a200000000
hexProcessTraceId: 05c623179f5a7b71
hexProcessSpanId: 2100595b908c6f1e
processTraceId: 416058599943076721
processSpanId: 2377998853053640478
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cc697e7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-22 23:03:16

Comparing candidate commit cc697e7 in PR branch bob/libdd-update with baseline commit b9a49fa in branch master.

Found 1 performance improvements and 17 performance regressions! Performance is the same for 174 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+5.862µs; +6.738µs] or [+42.171%; +48.477%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+19.852µs; +23.319µs] or [+9.128%; +10.722%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+15.413µs; +19.741µs] or [+7.024%; +8.996%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+21.462µs; +24.890µs] or [+9.884%; +11.463%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+17.085µs; +20.191µs] or [+7.862%; +9.291%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+106.740µs; +124.255µs] or [+12.750%; +14.842%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟥 execution_time [+82.136µs; +109.192µs] or [+9.222%; +12.260%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+49.839ns; +112.561ns] or [+3.587%; +8.101%]

scenario:SpanBench/benchDatadogAPI

  • 🟥 execution_time [+2.147µs; +5.207µs] or [+3.352%; +8.130%]

scenario:SpanBench/benchDatadogAPI-opcache

  • 🟥 execution_time [+1.901µs; +3.788µs] or [+2.935%; +5.848%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 execution_time [+23.432µs; +34.219µs] or [+3.264%; +4.766%]

scenario:SpanBench/benchOpenTelemetryAPI-opcache

  • 🟥 execution_time [+24.073µs; +33.345µs] or [+3.608%; +4.998%]

scenario:SpanBench/benchOpenTelemetryInteroperability-opcache

  • 🟥 execution_time [+3.713µs; +6.849µs] or [+2.134%; +3.937%]

scenario:SymfonyBench/benchSymfonyDdprof

  • 🟥 execution_time [+253.375µs; +358.025µs] or [+2.877%; +4.066%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

  • 🟥 execution_time [+248.028µs; +356.372µs] or [+2.833%; +4.070%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟥 execution_time [+296.394µs; +385.546µs] or [+3.634%; +4.727%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟥 execution_time [+299.040µs; +411.080µs] or [+3.624%; +4.982%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-24.535µs; -8.865µs] or [-5.683%; -2.054%]

@bwoebi bwoebi force-pushed the bob/libdd-update branch from 33adecd to 01ce985 Compare March 7, 2026 16:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (b9a49fa) to head (cc697e7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   68.77%   68.79%   +0.02%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
+ Hits        13087    13091       +4     
+ Misses       5127     5126       -1     
+ Partials      816      813       -3     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (-0.03%) ⬇️
helper-rust-unit 49.36% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a49fa...cc697e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi force-pushed the bob/libdd-update branch from 01ce985 to f9818fb Compare March 10, 2026 00:01
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from f9818fb to 8221b6f Compare March 11, 2026 19:47
@morrisonlevi morrisonlevi changed the title Update libdatadog to neweset Update libdatadog to newest Mar 11, 2026
@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-03-22 22:01:49

Comparing candidate commit cc697e7 in PR branch bob/libdd-update with baseline commit b9a49fa in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 25 metrics, 7 unstable metrics.

scenario:php-profiler-timeline-memory-control

  • 🟥 cpu_user_time [+31.434ms; +39.143ms] or [+5.199%; +6.475%]
  • 🟥 execution_time [+33.808ms; +39.876ms] or [+5.353%; +6.314%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 cpu_user_time [+23.880ms; +62.636ms] or [+2.048%; +5.372%]
  • 🟥 execution_time [+22.680ms; +38.698ms] or [+2.279%; +3.888%]

morrisonlevi and others added 7 commits March 12, 2026 09:02
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from ace997b to 5f42a8e Compare March 16, 2026 22:29
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 4 times, most recently from adf1aa4 to 2b42ae2 Compare March 17, 2026 02:38
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from 2b42ae2 to 992785f Compare March 17, 2026 14:32
bwoebi added 2 commits March 17, 2026 15:47
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi and others added 5 commits March 17, 2026 22:55
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  feat(sidecar): add thread mode as fallback connection for restricted environments (#3573)
  Migrate deprecated GitLab runner tags (#3715)
  Adds process tags to remote config payload (#3658)
  perf(config): cache sys getenv (#3670)
  Fixes the tag name for process tags (#3709)
  Fix debugger ephemerals handling (#3685)
  Fix #3651: Prevent crash during shutdown in Frankenphp (#3662)
  Add dynamic instrumentation and exception replay to startup logging (#3667)
  chore: bump bytes crate from 1.9.0 to 1.11.1 to address CVE-2026-25541 (#3669)
  Merge pull request #3701 from DataDog/brian.marks/add-ksr-tag
  ci: fix Windows job flakiness caused by dirty workspace (#3694)
  Fixup CI owner association (#3704)
  Add Rust rewrite of the AppSec helper alongside the C++ implementation
  Remove debug instruction
  Fix script order
  debug
  Fix exploration logic
  chore(ci): add final_status property on junit XML [APMSP-2610]
  Fix DD_TRACE_SYMFONY_HTTP_ROUTE=false
  Optimize Symfony http.route caching with path map approach
@bwoebi bwoebi force-pushed the bob/libdd-update branch from 37bfbff to e04172d Compare March 20, 2026 22:42
bwoebi and others added 5 commits March 21, 2026 00:09
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 3 times, most recently from d815db9 to 4d4c6ec Compare March 21, 2026 02:29
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 2 times, most recently from 4deda59 to d297ae2 Compare March 21, 2026 05:21
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from d297ae2 to ae57131 Compare March 21, 2026 06:27
bwoebi added 2 commits March 21, 2026 15:57
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 7 times, most recently from e860100 to 57c9b2c Compare March 22, 2026 20:41
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from 57c9b2c to cc697e7 Compare March 22, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants