Skip to content

Update datacenter_overview.json#23597

Merged
kylerkang merged 3 commits intomasterfrom
kylerkang-patch-1
May 7, 2026
Merged

Update datacenter_overview.json#23597
kylerkang merged 3 commits intomasterfrom
kylerkang-patch-1

Conversation

@kylerkang
Copy link
Copy Markdown
Contributor

@kylerkang kylerkang commented May 5, 2026

What does this PR do?

Making a few dashboard changes to the "Network Device Monitoring" OOTB Dashboard found in the dashboards dropdown. I had originally updated all the updated NDM OOTB dashboards, but for this specific one, the "Network Overview" is missing widgets since I made it a powerpack. I am adding those widgets back in this PR.

Found here:
image

Before:
image

After:
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acef9525bc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"hide_zero_counts": true,
"show_status": true,
"last_triggered_format": "relative",
"query": "tag:(createdby:billcain) * $interface *",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove hard-coded monitor creator filter

The new monitor summary query is constrained to createdby:billcain, which means the “Alerts sorted by severity” widget will only show monitors created by that specific user; in any other Datadog org (or even this org after ownership changes), the widget will appear empty and hide active alerts. This is a functional regression for the dashboard’s default experience and should be replaced with a reusable scope filter (or no creator filter).

Useful? React with 👍 / 👎.

victorsprengel
victorsprengel previously approved these changes May 6, 2026
Copy link
Copy Markdown
Contributor

@victorsprengel victorsprengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is datadog_demo_keep:true intentional here?

@kylerkang
Copy link
Copy Markdown
Contributor Author

Is datadog_demo_keep:true intentional here?

@victorsprengel no it is not, let me change that

@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed victorsprengel’s stale review May 6, 2026 17:15

Review from victorsprengel is dismissed. Related teams and files:

  • network-device-monitoring-core
    • snmp/assets/dashboards/datacenter_overview.json
@kylerkang kylerkang requested a review from victorsprengel May 6, 2026 17:15
@kylerkang kylerkang enabled auto-merge May 6, 2026 17:16
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@kylerkang kylerkang added this pull request to the merge queue May 7, 2026
Merged via the queue into master with commit 5b6c94f May 7, 2026
53 of 55 checks passed
@kylerkang kylerkang deleted the kylerkang-patch-1 branch May 7, 2026 08:57
@dd-octo-sts dd-octo-sts Bot added this to the 7.79.0 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants