feat(HELM): Make HPA more Argo-friendly #13882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiblik
force-pushed
the
helm_hpa_argo
branch
4 times, most recently
from
28e86f4 to
fdb4633
Compare
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: kiblik <[email protected]>
kiblik
force-pushed
the
helm_hpa_argo
branch
from
fdb4633 to
3826b37
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Maffooch
approved these changes
Dec 17, 2025
valentijnscholten
approved these changes
Dec 19, 2025
blakeaowens
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgoCD and similar systems do not like the usage of
replicasandHPA. As soon as you useHPA, the number ofreplicasis irrelevant.https://argo-cd.readthedocs.io/en/stable/user-guide/best_practices/#leaving-room-for-imperativeness