reimport: optimize vulnerability_id processing#13891
Closed
valentijnscholten wants to merge 4 commits intoDefectDojo:bugfixfrom
Closed
reimport: optimize vulnerability_id processing#13891valentijnscholten wants to merge 4 commits intoDefectDojo:bugfixfrom
valentijnscholten wants to merge 4 commits intoDefectDojo:bugfixfrom
Conversation
Member
Author
|
It's too time consuming to implement this separate from the batch reimport pr, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimport was overwriting vulnerability_ids for every finding in the report. Since this is a OneToMany field this is expensive.
This PR prefetches the existing vulnerability_ids and only updates them if the report being reimported has different vulnerability_ids for this finding. Also it gets rid of the duplicate delete query for existing findings.
on a reimport of the 13k jfrog sample report this saves almost 50% of time (117s -> 63s)
The pr also fixes a bug where a change in finding.cve was not persisted.
Also added some test cases.