Set last reviewed date and reviewer when note is added#14209
Merged
Set last reviewed date and reviewer when note is added#14209
Conversation
Update finding's last reviewed date and reviewer to maintain parity with UI behaviors
valentijnscholten
changed the title
Member
|
Should this also happen on notes added via the JIRA webhook? |
Maffooch
commented
Jan 29, 2026
Maffooch
requested review from
Jino-T,
blakeaowens,
paulOsinski and
valentijnscholten
Contributor
Author
Sure |
Update finding with last reviewed date and author.
Maffooch
commented
Jan 30, 2026
Jino-T
approved these changes
Jan 30, 2026
dojo/jira_link/views.py
Outdated
| finding.save() | ||
| finding.last_reviewed = new_note.date | ||
| finding.last_reviewed_by = author | ||
| finding.save(update_fields=["last_reviewed", "last_reviewed_by"]) |
Member
There was a problem hiding this comment.
I think "updated" should also be included
blakeaowens
approved these changes
Jan 30, 2026
Contributor
blakeaowens
left a comment
blakeaowens
left a comment
There was a problem hiding this comment.
Approved pending Val's comment.
Maffooch
commented
Jan 31, 2026
valentijnscholten
approved these changes
Jan 31, 2026
paulOsinski
approved these changes
Feb 2, 2026
Contributor
Author
|
Turns out that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update finding's last reviewed date and reviewer to maintain parity with UI behaviors