Skip to content

fix: update Qualys parser to support port-based findings#14288

Open
ArnaavSinghSandhu wants to merge 1 commit intoDefectDojo:devfrom
ArnaavSinghSandhu:fix-qualys-port-deduplication-V2
Open

fix: update Qualys parser to support port-based findings#14288
ArnaavSinghSandhu wants to merge 1 commit intoDefectDojo:devfrom
ArnaavSinghSandhu:fix-qualys-port-deduplication-V2

Conversation

@ArnaavSinghSandhu
Copy link

This PR replaces #14269

Changes:

Rebased: The branch is now fully up to date with the latest dev branch.

Parser Update: Improved port extraction logic in the Qualys parser.

Deduplication: As requested by @Maffooch, I have removed endpoints and port from the get_dedupe_fields list to maintain the existing deduplication behavior while still improving the data extraction.

Formatting: Ran ruff to ensure all linting and formatting follow the project's style guide.

@Maffooch
Copy link
Contributor

@ArnaavSinghSandhu something I had not considered sooner is that what happens to existing qualys findings after this parser change? Would the endpoint from previous imports still continue to be matched, or would they be marked as mitigated, and new endpoints with ports be created?

@ArnaavSinghSandhu
Copy link
Author

That's a good point, @Maffooch. Since the endpoint string is changing from just the IP to IP:Port, DefectDojo will indeed treat them as new EndPoint objects.

On the next import:

The old Endpoints (IP only) will likely be marked as mitigated because they are no longer present in the scan file in that exact format.

The new Endpoints (IP:Port) will be created.

However, because we removed endpoints from the get_dedupe_fields (as per your request), the Findings themselves will not duplicate. They will simply point to the new, more accurate endpoints.

@ArnaavSinghSandhu ArnaavSinghSandhu force-pushed the fix-qualys-port-deduplication-V2 branch from 06fb3c8 to 61604ad Compare February 13, 2026 01:32
@ArnaavSinghSandhu ArnaavSinghSandhu force-pushed the fix-qualys-port-deduplication-V2 branch from 61604ad to 34512a6 Compare February 13, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants