feat(parsers): add fix_version support to Generic Findings Import #14307
+67
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
fix_versionfield exists on the Finding model (CharField, max_length=100)and is already handled by the reimporter (
default_reimporter.pylines 683, 803),but was missing from the Generic Findings Import parser for both JSON and CSV formats.
This meant users could see and edit
fix_versionin the UI, but could notpopulate it via Generic Findings Import.
Changes:
json_parser.py: Addedfix_versionto theallowedfields setcsv_parser.py: Addedfix_versionfield parsingfix_versiondataTest results:
Added two unit tests in unittests/tools/test_generic_parser.py:
Also manually verified via API reimport that fix_version populates correctly
on findings.
Checklist:
dev.dev.bugfixbranch.