Skip to content

List: fix border cases on dragging first or last items using KBN (T1320189) #32334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmlvr merged 6 commits into from
Jan 30, 2026
Merged

List: fix border cases on dragging first or last items using KBN (T1320189) #32334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b59197b
add early exit to moveFocusedItem function
dmlvr Jan 28, 2026
4274646
add tests for this case
dmlvr Jan 28, 2026
38d46ae
fix by review comments
dmlvr Jan 29, 2026
6f0c38d
remove extra import
dmlvr Jan 29, 2026
2a0f355
rename result description for shift+arrowDown test
dmlvr Jan 29, 2026
ff867c6
add some additional early return basen on index checking
dmlvr Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/devextreme/js/__internal/ui/list/list.edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,19 @@ class ListEdit extends ListBase {

if (e.shiftKey && itemDragging?.allowReordering) {
const nextItemIndex = focusedItemIndex + (moveUp ? -1 : 1);

if (nextItemIndex < 0
|| nextItemIndex === NOT_EXISTING_INDEX
|| nextItemIndex > this._getLastItemIndex()) {
return;
}

const $nextItem = editStrategy.getItemElement(nextItemIndex);

if (!$nextItem) {
return;
}

const isMoveFromGroup = grouped
&& $(focusedElement).parent().get(0) !== $nextItem.parent().get(0);
if (!isMoveFromGroup) {
Expand Down
56 changes: 56 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/editingTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,62 @@ QUnit.module('keyboard navigation', {
assert.deepEqual(list.option('items'), items, 'items were reordered');
});

QUnit.test('shift+arrowUp on first item should not throw error (T1320189)', function(assert) {
const items = ['1', '2', '3'];

const $list = $('#list').dxList({
items: items,
editEnabled: true,
itemDragging: {
allowReordering: true
},
focusStateEnabled: true
});

const list = $list.dxList('instance');
const keyboard = keyboardMock($list.find('[tabindex=0]'));

const $firstItem = $list.find('.' + LIST_ITEM_CLASS).eq(0);
list.option('focusedElement', $firstItem.get(0));

let errorMessage = '';
try {
keyboard.keyDown('arrowUp', { shiftKey: true });
} catch(e) {
errorMessage = `error message: ${e.message}`;
}

assert.strictEqual(errorMessage, '', 'no error thrown when trying to move first item up');
});

QUnit.test('shift+arrowDown on last item should not throw error (T1320189)', function(assert) {
const items = ['1', '2', '3'];

const $list = $('#list').dxList({
items: items,
editEnabled: true,
itemDragging: {
allowReordering: true
},
focusStateEnabled: true
});
const list = $list.dxList('instance');
const keyboard = keyboardMock($list.find('[tabindex=0]'));

const $lastItem = $list.find('.' + LIST_ITEM_CLASS).eq(2);
list.option('focusedElement', $lastItem.get(0));

let errorMessage = '';
try {
keyboard.keyDown('arrowDown', { shiftKey: true });
} catch(e) {
errorMessage = `error message: ${e.message}`;
}

assert.strictEqual(errorMessage, '', 'no error thrown when trying to move last item down');
});


QUnit.module('grouped', {
beforeEach: function() {
this.getInitialItems = () => {
Expand Down
Loading