Skip to content

Chore: Gulp clean task migration#33694

Open
ajivanyandev wants to merge 4 commits into
DevExpress:26_1from
ajivanyandev:chore/gulp-clean-script
Open

Chore: Gulp clean task migration#33694
ajivanyandev wants to merge 4 commits into
DevExpress:26_1from
ajivanyandev:chore/gulp-clean-script

Conversation

@ajivanyandev
Copy link
Copy Markdown
Contributor

No description provided.

@ajivanyandev ajivanyandev requested a review from a team as a code owner May 25, 2026 11:56
Copilot AI review requested due to automatic review settings May 25, 2026 11:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the gulp clean task in packages/devextreme to delegate to the existing clean:artifacts Nx target, completing the gulp-to-Nx migration pattern already used for transpile, vectormap, aspnet, etc. The Nx target's exclusion list is extended to preserve artifacts/npm/devextreme-dist, matching the previous del.sync preservation behavior.

Changes:

  • Replaces the del.sync-based gulp clean body with shell.task('pnpm nx clean:artifacts devextreme') and removes the now-unused gulp-cache import.
  • Adds ./artifacts/npm/devextreme-dist to clean:artifacts.excludePatterns so the devextreme-dist package output is preserved across cleans (matches prior gulp behavior).
  • Documents the migration in .github/copilot-instructions.md and adds a "Migrated gulp tasks" section to packages/nx-infra-plugin/AGENTS.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/devextreme/gulpfile.js Replaces gulp clean implementation with a shell.task delegating to Nx; drops gulp-cache import.
packages/devextreme/project.json Adds ./artifacts/npm/devextreme-dist to clean:artifacts exclusions to preserve dist output.
.github/copilot-instructions.md Updates build-pipeline description to mention the Nx clean step and the gulp delegate.
packages/nx-infra-plugin/AGENTS.md Adds a "Migrated gulp tasks" section documenting the migration pattern.

Copilot AI review requested due to automatic review settings May 28, 2026 14:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants