Chore: Gulp clean task migration#33694
Open
ajivanyandev wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the gulp clean task in packages/devextreme to delegate to the existing clean:artifacts Nx target, completing the gulp-to-Nx migration pattern already used for transpile, vectormap, aspnet, etc. The Nx target's exclusion list is extended to preserve artifacts/npm/devextreme-dist, matching the previous del.sync preservation behavior.
Changes:
- Replaces the
del.sync-basedgulp cleanbody withshell.task('pnpm nx clean:artifacts devextreme')and removes the now-unusedgulp-cacheimport. - Adds
./artifacts/npm/devextreme-disttoclean:artifacts.excludePatternsso thedevextreme-distpackage output is preserved across cleans (matches prior gulp behavior). - Documents the migration in
.github/copilot-instructions.mdand adds a "Migrated gulp tasks" section topackages/nx-infra-plugin/AGENTS.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/gulpfile.js | Replaces gulp clean implementation with a shell.task delegating to Nx; drops gulp-cache import. |
| packages/devextreme/project.json | Adds ./artifacts/npm/devextreme-dist to clean:artifacts exclusions to preserve dist output. |
| .github/copilot-instructions.md | Updates build-pipeline description to mention the Nx clean step and the gulp delegate. |
| packages/nx-infra-plugin/AGENTS.md | Adds a "Migrated gulp tasks" section documenting the migration pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.