PivotGrid A11y and KBN - The headerfilter has an incorrect description in aria-label: there is no column name#33718
Merged
bit-byte0 merged 3 commits intoMay 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an accessibility issue in PivotGrid Field Chooser where header filter button aria-label could contain undefined when a field has an empty string caption and no dataField by switching from || to nullish coalescing (??) and adding a safe empty-string fallback.
Changes:
- Use
field.caption ?? field.dataField ?? ''when rendering field text. - Use the same nullish fallback for the
captionpassed into sort/headerFilter indicator column configs (preventsundefinedfrom flowing into the header filter indicatoraria-labelformatting).
siarhei-arzamasau
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix aria-label showing
undefinedon PivotGrid header filter buttonsHow
|| → ??in renderField.||treats''as falsy → falls toundefineddataField.??preserves''Verify
Add
{ area: 'column' }field (no dataField, no caption) to PivotGrid field panel. Inspect filter button → noundefinedin label