Skip to content

PivotGrid A11y and KBN - The headerfilter has an incorrect description in aria-label: there is no column name #33737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bit-byte0 merged 2 commits into from
May 27, 2026
+9 −4
Merged

PivotGrid A11y and KBN - The headerfilter has an incorrect description in aria-label: there is no column name #33737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13526b
fix(pivot-grid): use nullish coalescing for header filter aria-label …
bit-byte0 May 25, 2026
0d5e61a
test(pivot-grid): add regression case for undefined in header filter …
bit-byte0 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion e2e/testcafe-devextreme/tests/common/pivotGrid/fieldPanel/T1287521_fields_aria_label.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ test('Header fields should have correct aria-label', async (t) => {
.expect(columnHeader.getHeaderFilterIcon(1).ariaLabel)
.eql('Show filter options for column \'Column2\'')
.expect(filterHeader.getHeaderFilterIcon(0).ariaLabel)
.eql('Show filter options for column \'Column3\'');
.eql('Show filter options for column \'Column3\'')
.expect(columnHeader.getHeaderFilterIcon(2).ariaLabel)
.notContains('undefined');
}).before(async () => {
await createWidget('dxPivotGrid', {
allowFiltering: true,
Expand All @@ -43,6 +45,8 @@ test('Header fields should have correct aria-label', async (t) => {
}, {
dataField: 'column2',
area: 'column',
}, {
area: 'column',
}, {
dataField: 'column3',
area: 'filter',
Expand Down
7 changes: 4 additions & 3 deletions packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser_base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,9 @@ export class FieldChooserBase extends mixinWidget {

renderField(field, showColumnLines) {
const that = this;
const caption = field.caption ?? field.dataField ?? '';
const $fieldContent = $(DIV).addClass(CLASSES.area.fieldContent)
.text(field.caption || field.dataField);
.text(caption);
const $fieldElement = $(DIV)
.addClass(CLASSES.area.field)
.addClass(CLASSES.area.box)
Expand All @@ -191,7 +192,7 @@ export class FieldChooserBase extends mixinWidget {
alignment: that.option('rtlEnabled') ? 'right' : 'left',
sortOrder: field.sortOrder === 'desc' ? 'desc' : 'asc',
allowSorting: field.allowSorting,
caption: field.caption || field.dataField,
caption,
},
showColumnLines,
});
Expand All @@ -205,7 +206,7 @@ export class FieldChooserBase extends mixinWidget {
filterValues: mainGroupField.filterValues,
allowFiltering: mainGroupField.allowFiltering && !field.groupIndex,
allowSorting: field.allowSorting,
caption: field.caption || field.dataField,
caption,
},
showColumnLines,
});
Expand Down
Loading