Scheduler — Refactor scheduler.d.ts file#34363
Open
sjbur wants to merge 12 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Scheduler TypeScript declaration surface to align with the newer Properties/Item type-alias patterns used across DevExtreme and to simplify/normalize scheduler-related JSDoc/type references. It also updates the aggregated dx.all.d.ts bundle and adjusts Vue wrapper typings accordingly.
Changes:
- Switches
dxSchedulergenerics to useDevExpress.ui.dxScheduler.Properties/Propertiesaliases. - Refactors
DateNavigatorItemPropertiesto extenddxButtonGroup.Propertiesand usedxButtonGroup.Item. - Updates Scheduler event typings/JSDoc, including changes to
AppointmentUpdatingEvent.oldData/newData.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Updates bundled Scheduler declarations to use Properties/Item aliases and reflects event type changes. |
| packages/devextreme/js/ui/scheduler.d.ts | Refactors Scheduler public typings (imports, aliases, event payload types, and JSDoc cleanup). |
| packages/devextreme-vue/src/scheduler.ts | Updates Vue wrapper typings related to Scheduler toolbar item options. |
Comments suppressed due to low confidence (1)
packages/devextreme-vue/src/scheduler.ts:126
packages/devextreme-vue/src/**is generated output. Direct edits to this file are likely to be overwritten and can desync from the generators; update the generator/templates and rerun regeneration (e.g.,pnpm run regenerate-all) instead of committing manual changes here.
import {
dxButtonGroupItem,
ContentReadyEvent as ButtonGroupContentReadyEvent,
DisposingEvent as ButtonGroupDisposingEvent,
InitializedEvent as ButtonGroupInitializedEvent,
aleksei-semikozov
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.