build(agent): update now-policy-api to 0.3.1 - #1928
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Pull request overview
Updates broker tests to validate package identifiers through PackageIdentifier::parse, while retaining direct construction for defense-in-depth cases.
Changes:
- Validates positive-path test identifiers using wire-equivalent parsing.
- Documents intentional validation bypasses in malicious-input tests.
- Adds control-character rejection coverage.
- Currently blocked by
now-policy-api0.3.1 availability and lockfile update.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
devolutions-agent/src/broker/server/mod.rs |
Parses the server test identifier. |
devolutions-agent/src/broker/evaluator/tests.rs |
Parses evaluator test identifiers. |
devolutions-agent/src/broker/evaluator/matching.rs |
Parses the matching fixture identifier. |
devolutions-agent/src/broker/evaluator/constraints.rs |
Parses the constraints fixture identifier. |
devolutions-agent/src/broker/command_builder/winget.rs |
Parses the WinGet identifier. |
devolutions-agent/src/broker/command_builder/vcpkg.rs |
Validates vcpkg identifiers and documents bypass cases. |
devolutions-agent/src/broker/command_builder/scoop.rs |
Parses the Scoop identifier. |
devolutions-agent/src/broker/command_builder/powershell.rs |
Parses PowerShell package identifiers. |
devolutions-agent/src/broker/command_builder/pip.rs |
Parses valid pip identifiers and documents malicious cases. |
devolutions-agent/src/broker/command_builder/npm.rs |
Validates npm aliases and control-character rejection. |
devolutions-agent/src/broker/command_builder/dotnet.rs |
Parses the .NET package identifier. |
devolutions-agent/src/broker/command_builder/chocolatey.rs |
Parses the Chocolatey identifier. |
devolutions-agent/src/broker/command_builder/cargo.rs |
Parses Cargo test identifiers. |
devolutions-agent/src/broker/command_builder/bun.rs |
Validates scoped Bun identifiers. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1e10426 to
e1c411c
Compare
e1c411c to
0fca202
Compare
The 0.3.1 release relaxes the PackageIdentifier wire validation to an allowlist admitting scoped npm identifiers, npm aliases, and vcpkg triplets, which the broker command builders already support. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
0fca202 to
52ec527
Compare
6bfe09d
into
master
Updates now-policy-api to 0.3.1, which relaxes the PackageIdentifier wire validation to an allowlist admitting scoped npm identifiers (
@scope/package), npm aliases (alias:@scope/package@1.2.3), and vcpkg triplets (curl:x64-windows). These identifier forms are already supported by the broker command builders but were previously rejected during request deserialization by 0.3.0.