IES updates #965
IES updates #965
Conversation
small change to make sure `ditt` doesn't autodelete
…ubresource bitflags to not trigger asserts, update examples_tests submodule
…experimental, no real validation), update examples_tests submodule
…arguments in json payload, CI should pass now
…ate examples_tests
…ODO on how to improve it even more
… with GPU converter, encode to EF_A2R10G10B10_UNORM_PACK32, update examples_tests submodule
…into ies # Conflicts: # examples_tests
| inline float32_t __call(NBL_CONST_REF_ARG(Accessor) accessor, NBL_CONST_REF_ARG(float32_t2) uv) NBL_CONST_MEMBER_FUNC | ||
| { | ||
| const float32_t2 halfMinusHalfPixel = float32_t2(0.5f, 0.5f) / (float32_t2(1.f, 1.f) + info.lastTexelRcp); | ||
| const float32_t2 ndc = (uv - float32_t2(0.5f, 0.5f)) / halfMinusHalfPixel; |
There was a problem hiding this comment.
my bad I made this more complicated than should be, seems there should be two separate procedural textures (one for __call with integer texel coordinates and antother for __call with UV) which inherit a base one (where __call takes NDC) and they should have different infos (lastTexelRcp for first and halfMinusHalfTexel for other)
Now neither is fast.
There was a problem hiding this comment.
althought I guess we never really use this while shading, so no changes needed
| template<typename Accessor> | ||
| inline float32_t __evalNDC(NBL_CONST_REF_ARG(Accessor) accessor, NBL_CONST_REF_ARG(float32_t2) ndc) NBL_CONST_MEMBER_FUNC |
There was a problem hiding this comment.
NBL_FUNC_REQUIRE that Accessor fists a concept
| inline candela_t operator()(NBL_CONST_REF_ARG(accessor_t) accessor, NBL_CONST_REF_ARG(polar_t) polar) NBL_CONST_MEMBER_FUNC | ||
| { | ||
| assert(polar.theta >= float32_t(0.0) && polar.theta <= numbers::pi<float32_t>); | ||
| assert(hlsl::abs(polar.phi) <= numbers::pi<float32_t> * float32_t(2.0)); |
There was a problem hiding this comment.
huh why do you allow -2*pi < phi < 2*pi ?
There was a problem hiding this comment.
and that one I probably broke/typoed
2 participants
No description provided.