Skip to content

Minor post master merge clean-up#994

Merged
devshgraphicsprogramming merged 5 commits intomasterfrom
mCleanup
Feb 5, 2026
Merged

Minor post master merge clean-up#994
devshgraphicsprogramming merged 5 commits intomasterfrom
mCleanup

Conversation

@AnastaZIuk
Copy link
Member

No description provided.

@AnastaZIuk AnastaZIuk marked this pull request as ready for review February 2, 2026 07:56
@devshgraphicsprogramming
Copy link
Member

Can you remove the following:

setTranslation should move to fast_affine.hlsl because the encoding of a translation in the last column of a Nx(N+1) matrix is really an affine thing

they have requivalents here:
https://github.com/Devsh-Graphics-Programming/Nabla/blob/47bfd0478771eaab2ca849d0fcb5d5983ace47ff/include/nbl/builtin/hlsl/math/linalg/matrix_utils.hlsl
and in the quaternions for the angle-axis thing

also linalg/matrix_utils.hlsl should have a better name like linalg/basic.hlsl or core to avoid confusion with the other matrix_utils (the folder higher up)

@devshgraphicsprogramming devshgraphicsprogramming merged commit d41ab5b into master Feb 5, 2026
39 of 49 checks passed
@devshgraphicsprogramming devshgraphicsprogramming deleted the mCleanup branch February 5, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants