LIMS-2206: Assume DHL when no courier specified#1073
Open
ndg63276 wants to merge 1 commit into
Open
Conversation
gfrn
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2206
Summary:
When the shipping service is used, it doesn't specify a courier when sending data back to ispyb. If Synchweb is trying to track a shipment, and the courier is blank, we should assume DHL. There is a check for the correct number of digits anyway.
Changes:
To test:
update Shipping set deliveryAgent_agentName="" where shippingId=80525;update Shipping set deliveryAgent_agentName=NULL where shippingId=80525;