Skip to content

LIMS-2206: Assume DHL when no courier specified#1073

Open
ndg63276 wants to merge 1 commit into
masterfrom
fix/LIMS-2206/assume-dhl-when-no-courier
Open

LIMS-2206: Assume DHL when no courier specified#1073
ndg63276 wants to merge 1 commit into
masterfrom
fix/LIMS-2206/assume-dhl-when-no-courier

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2206

Summary:

When the shipping service is used, it doesn't specify a courier when sending data back to ispyb. If Synchweb is trying to track a shipment, and the courier is blank, we should assume DHL. There is a check for the correct number of digits anyway.

Changes:

  • Assume DHL if courier is blank or null

To test:

  • This has been deployed to ispyb-dev-3, complete with DHL credentials
  • Go to a recently shipped DHL dewar eg /shipments/sid/80525
  • Check tracking is working, eg
image
  • Set the courier blank and repeat the check, ie

update Shipping set deliveryAgent_agentName="" where shippingId=80525;

  • Set the courier to NULL and repeat the check, ie

update Shipping set deliveryAgent_agentName=NULL where shippingId=80525;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants