Trigger rebuilds on both [web.watcher].watch_path (in the config but not wired up) and cargo's depinfo #5042
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The watch_path config field was added but never consumed after the CLI rewrite in PR DioxusLabs#3797 - Now watches additional paths specified in Dioxus.toml [web.watcher].watch_path
- When cargo:rerun-if-changed=dir is used, the depinfo contains the directory path - Now checks if changed files are under any depinfo directory, not just exact matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hullo hullo – as described. In using build.rs with Dioxus, I found that there wasn't a way (any more) to get the watcher to rebuild on custom input paths.
I'm using
rerun-if-changed– I first tried usingwatch_path, but it looks like that got un-wired in #3797. I also wired up support for directories in rerun-if-changed as well.