Skip to content

Conversation

@Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Dec 22, 2025

  • Fixes installation using uv 0.9.16 or newer on musl/Alpine platforms (this only allows installing the SDK stub without C/C++-SDK-based implementation)
  • Removes hard dependency on pkg_resources, which should allow installation with setuptools>=81.
  • Fixes filename of pyproject.toml to prevent potential issues with outdated or missing setuptools.

Update to doc (gh-pages) in #41

@Oberon00 Oberon00 requested a review from Copilot December 22, 2025 14:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares version 1.5.2 to address installation issues with newer tools (uv 0.9.16+, setuptools 81+) and musl/Alpine platforms. The changes focus on packaging and compatibility improvements without modifying the SDK's core functionality.

Key changes:

  • Removes hard dependency on pkg_resources by wrapping it in a try-except block
  • Updates supported Python version range from 3.4-3.12 to 3.8-3.12
  • Clarifies musl libc limitations in error messages

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tox.ini Removes deprecated Python versions (3.4-3.7) from test environments
src/oneagent/version.py Bumps version number from 1.5.1 to 1.5.2
setup.py Makes pkg_resources optional, removes unused adjust_plat_name function, clarifies musl libc support message, removes outdated Python version classifiers
setup.cfg Adds comment clarifying actual Python 3.8+ requirement despite universal wheel claim
README.md Updates release notes and corrects project.toml to pyproject.toml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

glibc = '\nGNU libc version: ' + glibc_ver + '\n'
elif os.name != 'nt':
glibc = '\nNot using GNU libc. Note that musl libc is not supported.\n'
glibc = ('\nNot using GNU libc. Note that musl libc is not supported' +
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string concatenation across two lines is unnecessary. This could be a single string literal or use implicit string concatenation without the '+' operator for better readability.

Suggested change
glibc = ('\nNot using GNU libc. Note that musl libc is not supported' +
glibc = ('\nNot using GNU libc. Note that musl libc is not supported'

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to back-syncing requirements to internal mirror, not worth it at the moment. If more changes become necessary, will add that one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants