Skip to content

Upgrade internal icons to FontAwesome 7#7156

Open
Seb33300 wants to merge 1 commit intoEasyCorp:4.xfrom
Seb33300:icons
Open

Upgrade internal icons to FontAwesome 7#7156
Seb33300 wants to merge 1 commit intoEasyCorp:4.xfrom
Seb33300:icons

Conversation

@Seb33300
Copy link
Copy Markdown
Contributor

@Seb33300 Seb33300 commented Oct 20, 2025

Upgrade internal icons to FontAwesome 7

Note: Created as draft for now because it looks like there is an issue with the new icons, some of them are cropped: FortAwesome/Font-Awesome#20831

@Seb33300 Seb33300 changed the title Add details action icon + Upgrade FontAwesome Upgrade internal icons to FontAwesome 7 Oct 20, 2025
@javiereguiluz
Copy link
Copy Markdown
Collaborator

In the related issue that you opened in FontAwesome, they replied that this is intended and we must use overflow to let the new icons grow beyond the original size. Not sure how it's going to look in the UI 😐

@Seb33300
Copy link
Copy Markdown
Contributor Author

Yeah, that's a weird decision.
But they also suggested to use the full SVG version.

Full SVG are all the same size (square images) with margin on sides:
https://github.com/FortAwesome/Font-Awesome/blob/7.x/svgs-full/solid/lock.svg
https://github.com/FortAwesome/Font-Awesome/blob/7.x/svgs-full/solid/arrow-up.svg

Should we try to use full size instead?
They may look a bit smaller, but the good point is that all icons will have the exact same size.

@javiereguiluz
Copy link
Copy Markdown
Collaborator

Should we try to use full size instead?

Yes, I think that makes sense. We can make some CSS tweaks if neede to fix some size issues. If this is too much work, don't worry: just update the icons and I'll take the time to fix the CSS issues. Thanks!

@Seb33300 Seb33300 force-pushed the icons branch 2 times, most recently from 928e745 to f35a9ea Compare February 10, 2026 04:25
@Seb33300 Seb33300 marked this pull request as ready for review February 10, 2026 04:26
@Seb33300
Copy link
Copy Markdown
Contributor Author

@javiereguiluz finally updated all icons.

I tested it locally and noticed many small icon positioning issues.
So it would require additional work to readjust all the icon positions. I’m not sure it’s worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants