-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix tests #7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javiereguiluz
wants to merge
47
commits into
EasyCorp:5.x
Choose a base branch
from
javiereguiluz:fix_tests
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix tests #7190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2199ba3 to
db74c4f
Compare
This PR was squashed before being merged into the 4.x branch. Discussion ---------- Actions extensions This PR allows to define extensions that add/remove/modify actions at runtime. Commits ------- dafa4c1 Actions extensions
…ryuk) This PR was merged into the 4.x branch. Discussion ---------- [feature] Autocomplete for EntityFilter Autocomplete feature for entity filters Closes EasyCorp#6348 EasyCorp#4244 [Screencast_20251110_152014.webm](https://github.com/user-attachments/assets/7134ab2b-c49e-45d6-9e13-1abbb83035d0) Commits ------- 0202a8f [feature] Autocomplete for EntityFilter
Added the missing fill tag on recently introduced "detail "icon
This PR was merged into the 4.x branch. Discussion ---------- [BUG] Fixed detail icon color Added the missing fill tag on recently introduced "detail "icon (introduced in EasyCorp#7157 ) This avoids this issue in dark mode : <img width="170" height="132" alt="CleanShot 2025-11-11 at 17 41 37" src="https://github.com/user-attachments/assets/be14fcfe-9f79-4957-ad66-ce7c4f3299bd" /> Commits ------- 344bd17 Fixed detail icon color
…sion in autocomplete (johndodev) This PR was squashed before being merged into the 4.x branch. Discussion ---------- Ensure UUID mapping is checked before binary conversion in autocomplete Fix EasyCorp#7229 Commits ------- 3c6c735 Ensure UUID mapping is checked before binary conversion in autocomplete
…csi) This PR was merged into the 4.x branch. Discussion ---------- Fix some more deprecations related to Doctrine ``` User Deprecated: Using ArrayAccess on Doctrine\ORM\Mapping\FieldMapping is deprecated and will not be possible in Doctrine ORM 4.0. ``` [ComparisonConfigurator](https://github.com/EasyCorp/EasyAdminBundle/blob/4.x/src/Filter/Configurator/ComparisonConfigurator.php) [DateTimeConfigurator](https://github.com/EasyCorp/EasyAdminBundle/blob/4.x/src/Filter/Configurator/DateTimeConfigurator.php) [NumericConfigurator](https://github.com/EasyCorp/EasyAdminBundle/blob/4.x/src/Filter/Configurator/NumericConfigurator.php) Commits ------- 51d40d6 Fix some more deprecations related to Doctrine
…ien Richarte) This PR was squashed before being merged into the 4.x branch. Discussion ---------- Fix colors not applied on button disable state Hi, fix this issue : EasyCorp#7217 Commits ------- 2ad0932 Fix colors not applied on button disable state
…anslatorInterface mock (xabbuh) This PR was merged into the 4.x branch. Discussion ---------- use the IdentityTranslator instead of a custom TranslatorInterface mock Commits ------- aa897df use the IdentityTranslator instead of a custom TranslatorInterface mock
This PR was merged into the 4.x branch. Discussion ---------- use Composer 2.8 to install dependencies Commits ------- 291cc59 use Composer 2.8 to install dependencies
…atible with Symfony 8 (xabbuh) This PR was merged into the 4.x branch. Discussion ---------- remove workaround, DoctrineFixturesBundle is compatible with Symfony 8 Commits ------- 2aa6220 remove workaround, DoctrineFixturesBundle is compatible with Symfony 8
With the filter autocomplete, there was some issue
…emo) This PR was merged into the 4.x branch. Discussion ---------- Enhance content header help with pointer cursor This pull request makes a minor improvement to the user interface by moving the `cursor: pointer` style from the `.content-header-help i` selector to the parent `.content-header-help` selector. This ensures the pointer cursor appears when hovering over the entire help area, not just the icon (which isn't `<i>`, by the way). - UI improvement: * Moved `cursor: pointer` from `.content-header-help i` to `.content-header-help` for better hover behavior. Commits ------- f19258d Enhance content header help with pointer cursor
This PR was merged into the 4.x branch. Discussion ---------- Fix translation domain for flash messages Fix the flash message rendering in `templates/flash_messages.html.twig` by assigning the translated message to a variable before rendering. The `trans_default_domain` isn't working as expected because twig component `<twig:ea:Alert>` isn't "aware" of the context. See EasyCorp#7197 Commits ------- 6bfbea9 Fix translation domain for flash messages
…s (Snowbaha) This PR was merged into the 4.x branch. Discussion ---------- FIX: Handle potential null for excludedPropertyNames With the [filter autocomplete](EasyCorp@a637449) , there was some issue with the index "renderFilters" <img width="1236" height="824" alt="image" src="https://github.com/user-attachments/assets/2cadaabf-7d9a-4445-8dc5-16c99187370b" /> After the fix, you can have the result: <img width="1340" height="371" alt="image" src="https://github.com/user-attachments/assets/80d8ad0d-8bf1-4f68-bec0-67cb32422d53" /> Commits ------- f383ed9 FIX: Handle potential null for excludedPropertyNames
…orrect typos (gremo) This PR was merged into the 4.x branch. Discussion ---------- Fix Italian translations for boolean values and correct typos This pull request makes a few improvements to the Italian translations in `EasyAdminBundle.it.php`, correcting spelling and grammar issues to provide more accurate and natural translations. Translation corrections: * Corrected the translation for boolean "true" from "Si" to "Sì" to use the proper accented form. * Fixed a typo in the batch action modal content, changing "annulare" to the correct "annullare". * Improved the phrasing of comparison labels, changing "maggiore o uguale di" and "minore o uguale di" to the grammatically correct "maggiore o uguale a" and "minore o uguale a". Commits ------- 71990c0 Fix Italian translations for boolean values and correct typos in action messages
…(gremo) This PR was merged into the 4.x branch. Discussion ---------- Hide empty button labels when using button icons This pull request introduces a minor UI improvement to button components in the EasyAdmin theme. The main change ensures that if a button's label is empty, the label element will not be displayed, resulting in cleaner button rendering. Button rendering improvement: * In `buttons.css`, added a rule so that `.btn-label` elements that are empty and directly follow a `.btn-icon` within a `.btn` will be hidden from display. Commits ------- 1709464 Hide empty button labels when using button icons
…sting display and margin (gremo) This PR was merged into the 4.x branch. Discussion ---------- Improve form action rendering in datagrid by adjusting display and margin See EasyCorp#7249. This pull request introduces a small UI improvement for action buttons in data grids. Specifically, it adjusts the display and spacing of forms within action cells that are not rendered as dropdowns. - UI/Styling Improvements: * In `assets/css/easyadmin-theme/datagrids.css`, forms inside `.datagrid td.actions` cells (excluding those with the `.actions-as-dropdown` class) are now displayed inline and given horizontal margins for better spacing. Commits ------- 3d10b21 Improve form action rendering in datagrid by adjusting display and margins
…tomOption Widget Autocomplete is set (Patrick Perry) This PR was merged into the 4.x branch. Discussion ---------- setDefaultColumns didn't work on ChoiceField if CustomOption Widget Autocomplete is set fix EasyCorp#7239 just check if value is not set before, to avoid breaking projects that specifically rely on the classes. An alternative would be to delete the line. Commits ------- 9e3cfe2 check if already a defaultColumns exist before overwritting customized one.
…ct connect (deksor) This PR was merged into the 4.x branch. Discussion ---------- Added autocomplete connect event to ALL tomselect connect After doing this PR back in july EasyCorp#7048 I realize that I forgot to add the same events for the two other kinds of TomSelect when they connect ... My project has some remote data autocomplete, so I need to listen to these events as well. I also took into consideration the tweaks made here EasyCorp#7087 (I didn't see that PR back then, but note that you could also access the select field via event.detail.tomSelect.input ) Commits ------- c7ad0a2 Added autocomplete connect event to ALL tomselect connect
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
This PR was merged into the 4.x branch. Discussion ---------- Bump actions/checkout from 5 to 6 Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update README to include Node.js 24 support details and requirements by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2248">actions/checkout#2248</a></li> <li>Persist creds to a separate file by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2286">actions/checkout#2286</a></li> <li>v6-beta by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2298">actions/checkout#2298</a></li> <li>update readme/changelog for v6 by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2311">actions/checkout#2311</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v5.0.0...v6.0.0">https://github.com/actions/checkout/compare/v5.0.0...v6.0.0</a></p> <h2>v6-beta</h2> <h2>What's Changed</h2> <p>Updated persist-credentials to store the credentials under <code>$RUNNER_TEMP</code> instead of directly in the local git config.</p> <p>This requires a minimum Actions Runner version of <a href="https://github.com/actions/runner/releases/tag/v2.329.0">v2.329.0</a> to access the persisted credentials for <a href="https://docs.github.com/en/actions/tutorials/use-containerized-services/create-a-docker-container-action">Docker container action</a> scenarios.</p> <h2>v5.0.1</h2> <h2>What's Changed</h2> <ul> <li>Port v6 cleanup to v5 by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2301">actions/checkout#2301</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v5...v5.0.1">https://github.com/actions/checkout/compare/v5...v5.0.1</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>V6.0.0</h2> <ul> <li>Persist creds to a separate file by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2286">actions/checkout#2286</a></li> <li>Update README to include Node.js 24 support details and requirements by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2248">actions/checkout#2248</a></li> </ul> <h2>V5.0.1</h2> <ul> <li>Port v6 cleanup to v5 by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2301">actions/checkout#2301</a></li> </ul> <h2>V5.0.0</h2> <ul> <li>Update actions checkout to use node 24 by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li> </ul> <h2>V4.3.1</h2> <ul> <li>Port v6 cleanup to v4 by <a href="https://github.com/ericsciple"><code>@ericsciple</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2305">actions/checkout#2305</a></li> </ul> <h2>V4.3.0</h2> <ul> <li>docs: update README.md by <a href="https://github.com/motss"><code>@motss</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li> <li>Add internal repos for checking out multiple repositories by <a href="https://github.com/mouismail"><code>@mouismail</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li> <li>Documentation update - add recommended permissions to Readme by <a href="https://github.com/benwells"><code>@benwells</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li> <li>Adjust positioning of user email note and permissions heading by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li> <li>Update README.md by <a href="https://github.com/nebuk89"><code>@nebuk89</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li> <li>Update CODEOWNERS for actions by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li> <li>Update package dependencies by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li> </ul> <h2>v4.2.2</h2> <ul> <li><code>url-helper.ts</code> now leverages well-known environment variables by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li> <li>Expand unit test coverage for <code>isGhes</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li> </ul> <h2>v4.2.1</h2> <ul> <li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li> </ul> <h2>v4.2.0</h2> <ul> <li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li> <li>Dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li> </ul> <h2>v4.1.7</h2> <ul> <li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li> <li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li> <li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li> </ul> <h2>v4.1.6</h2> <ul> <li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li> </ul> <h2>v4.1.5</h2> <ul> <li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li> <li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li> <li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li> <li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/1af3b93b6815bc44a9784bd300feb67ff0d1eeb3"><code>1af3b93</code></a> update readme/changelog for v6 (<a href="https://redirect.github.com/actions/checkout/issues/2311">#2311</a>)</li> <li><a href="https://github.com/actions/checkout/commit/71cf2267d89c5cb81562390fa70a37fa40b1305e"><code>71cf226</code></a> v6-beta (<a href="https://redirect.github.com/actions/checkout/issues/2298">#2298</a>)</li> <li><a href="https://github.com/actions/checkout/commit/069c6959146423d11cd0184e6accf28f9d45f06e"><code>069c695</code></a> Persist creds to a separate file (<a href="https://redirect.github.com/actions/checkout/issues/2286">#2286</a>)</li> <li><a href="https://github.com/actions/checkout/commit/ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493"><code>ff7abcd</code></a> Update README to include Node.js 24 support details and requirements (<a href="https://redirect.github.com/actions/checkout/issues/2248">#2248</a>)</li> <li>See full diff in <a href="https://github.com/actions/checkout/compare/v5...v6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Commits ------- 91f09e3 Bump actions/checkout from 5 to 6
17a9ec1 to
2e4af42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.