Fix person form UX issues#1306
Open
fbacall wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the “people” nested form UX for authors/contributors/etc by ensuring dynamically added entries behave correctly across validation errors, can be removed reliably, and have autocomplete bound consistently.
Changes:
- Render stable (non-
replace-me) indices for unsaved people rows. - Refactor
PeopleJS to centralize autocomplete binding and apply it to existing rows. - Bind delete behavior via delegated events so it works for newly added rows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/views/common/_people_form.html.erb | Updates the index used for person sub-forms to avoid replace-me for unsaved entries. |
| app/assets/javascripts/people.js | Refactors binding to fix autocomplete on existing rows and deletion on newly added rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
26
| <% f.object.send(field_name).each_with_index do |person, index| %> | ||
| <%= render partial: 'common/person_form', | ||
| locals: { field_prefix: "#{model_name}[#{field_name}]", index: person.id, person: person, role: role } %> | ||
| locals: { field_prefix: "#{model_name}[#{field_name}]", index: person.id || (index + 1), person: person, role: role } %> | ||
| <% end %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
See above.
Checklist