Improve column hover-over text#826
Merged
jamie-m-a merged 3 commits intoEnsembl:mainfrom Feb 26, 2026
Merged
Conversation
jamie-m-a
requested changes
Feb 25, 2026
Contributor
jamie-m-a
left a comment
jamie-m-a
left a comment
There was a problem hiding this comment.
Has this been tested in sandbox to confirm hover text working as expected?
| $header{"SpliceAI_pred_DP_AG"} = "SpliceAI ($spliceai_version) delta position (bp) for acceptor gain: position (relative to variant) of max AG change (+ downstream, − upstream)."; | ||
| $header{"SpliceAI_pred_DP_AL"} = "SpliceAI ($spliceai_version) delta position (bp) for acceptor loss: position (relative to variant) of max AL change (+ downstream, − upstream)."; | ||
| $header{"SpliceAI_pred_DP_DG"} = "SpliceAI ($spliceai_version) delta position (bp) for donor gain: position (relative to variant) of max DG change (+ downstream, − upstream)."; | ||
| $header{"SpliceAI_pred_DP_DL"} = "SpliceAI ($spliceai_version) delta position (bp) for donor loss: position (relative to variant) of max DL change (+ downstream, − upstream)."; else { |
Contributor
There was a problem hiding this comment.
Looks like there's a bracket missing before the else?
Contributor
Author
There was a problem hiding this comment.
Ah yes, good spot. Fixed, then ran:
perl -c SpliceAI.pm SpliceAI.pm syntax OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ENSVAR-6950.