Preserve Search context when leaving a thread#94114
Open
marufsharifi wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a user leaves a thread from
Spend>Chats, the app should return to the correct parent Search-owned report route instead of redirecting toInboxor a stale recent-report route. This change keeps both direct thread leaves and workspace-opened thread leaves in Search context by reusing the current thread’s parent route andbackTochain.Fixed Issues
$ #85560
PROPOSAL: #85560 (comment)
Tests
Spend>Chats.Leave.InboxOffline tests
Same as tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-20.at.5.56.40.PM.mov
Android: mWeb Chrome
Screen_Recording_20260620_180406_Chrome.mp4
iOS: Native
Screen.Recording.2026-06-20.at.6.09.15.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-06-20.at.6.56.23.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-20.at.5.38.06.PM.mov