Skip to content

Preserve Search context when leaving a thread#94114

Open
marufsharifi wants to merge 1 commit into
Expensify:mainfrom
marufsharifi:fix/preserve-search-context-when-leaving-thread
Open

Preserve Search context when leaving a thread#94114
marufsharifi wants to merge 1 commit into
Expensify:mainfrom
marufsharifi:fix/preserve-search-context-when-leaving-thread

Conversation

@marufsharifi

@marufsharifi marufsharifi commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

When a user leaves a thread from Spend > Chats, the app should return to the correct parent Search-owned report route instead of redirecting to Inbox or a stale recent-report route. This change keeps both direct thread leaves and workspace-opened thread leaves in Search context by reusing the current thread’s parent route and backTo chain.

Fixed Issues

$ #85560
PROPOSAL: #85560 (comment)

Tests

  1. Go to Spend > Chats.
  2. Open a thread from Search.
  3. Open the thread details/header.
  4. Click Leave.
  5. Verify you return to the correct parent Search-owned report route.
  6. Verify the app does not redirect to Inbox
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-06-20.at.5.56.40.PM.mov
Android: mWeb Chrome
Screen_Recording_20260620_180406_Chrome.mp4
iOS: Native
Screen.Recording.2026-06-20.at.6.09.15.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-06-20.at.6.56.23.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-20.at.5.38.06.PM.mov

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/actions/Report/index.ts 70.11% <50.00%> (-0.13%) ⬇️
... and 8 files with indirect coverage changes

@marufsharifi marufsharifi marked this pull request as ready for review June 20, 2026 14:38
@marufsharifi marufsharifi requested review from a team as code owners June 20, 2026 14:38
@melvin-bot melvin-bot Bot requested review from sobitneupane and trjExpensify and removed request for sobitneupane June 20, 2026 14:38
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed request for a team June 20, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant