feat: Make the Workspace and Domain member filter list multi-select, and update All members to Members (V2)

[samranahm]

Explanation of Change

Add multi-select filters on Workspace members (role) and Domain Members (group), replacing single-select dropdowns so users can filter by multiple roles or groups at once. Filter label text now show selected values with proper truncation when sharing a row with search bar.

Fixed Issues

$ #90637
PROPOSAL: #90637 (comment)

Tests

Precondition:

• Admin create a workspace and invite some members, admins and auditors and make some members approvers.
• Set up a private domain in Expensify and invite members using email addresses associated with that domain.

Test 01

1. Open the Workspace Members page and verify that the “Role: All” filter dropdown button is displayed.
2. Click the “Role: All” button and verify that the multi-select list is displayed with 3 roles (or 4 roles, including “Auditor” for Control workspaces).
3. Select multiple role options, click “Apply”, and verify that only members matching the selected filters are displayed.
4. Verify that the dropdown button text displays the selected filter values separated by commas and has prefix “Role: ” (e.g., Role: Members, Admins, Approvers).
5. Select only the “Members” role option, click “Apply”, and verify that only users who are not admins, approvers, or auditors are displayed.
6. Reopen the filter, click “Reset”, and verify that all members are displayed.

Test 02

1. Open the Workspaces tab and select a connected domain from the “Domains” section.
2. Open the “Domain Members” page and verify that all members associated with the domain are listed along with their groups (for example: Employees, Managers).
3. Verify that the “Group: All” filter dropdown button is displayed.
4. Open the filter and verify that all available groups are displayed, and that there is no “Members” or “All members” option.
5. Select multiple group filters, click “Apply”, and verify that only members matching the selected groups are displayed.
6. Select a single group filter (e.g., Managers), click “Apply”, and verify that only members belonging to that group are displayed and that the button text changes to Group: Managers.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mWeb.Chrome.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

IOS.mWeb.Safari.mp4

MacOS: Chrome / Safari

macOS.Chrome.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e59f3778be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Clear unavailable role filters before applying them

If the workspace type changes while this page is mounted, selectedRoleFilters can still contain roles that are no longer present in roleFilterOptions (for example, select Auditor/Card Admin on a Control workspace, then switch to a Collect workspace or receive that policy update). Because the filter still iterates over the stale selected values here, the member list remains filtered by a role that the dropdown no longer shows, and the label can degrade to Role: with no checked item to unselect except using Reset. Please derive the active selection from the current roleFilterOptions before filtering/labeling, like the previous fallback did.

Useful? React with 👍 / 👎.

[samranahm]

Yes this can be happen as edge case, I'll update theeffectiveRoleFilter behavior for multi-select by deriving effectiveSelectedRoleFilters from the current roleFilterOptions before filtering and labeling. That will prevents stale role selections from sticking around after the workspace type changes to collect or any group removed in domain members.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	93.84% <ø> (ø)
...nts/Search/FilterDropdowns/MembersFilterButton.tsx	100.00% <100.00%> (ø)
src/hooks/useDomainGroupFilter.ts	100.00% <100.00%> (ø)
src/pages/domain/Members/DomainMembersPage.tsx	0.00% <0.00%> (ø)
src/pages/domain/BaseDomainMembersPage.tsx	0.00% <0.00%> (ø)
src/pages/workspace/WorkspaceMembersPage.tsx	63.65% <70.58%> (+2.52%)	⬆️
... and 72 files with indirect coverage changes