Skip to content

Add August product marketing window - #98565

Draft
KJ21-ENG wants to merge 3 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window
Draft

Add August product marketing window#98565
KJ21-ENG wants to merge 3 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window

Conversation

@KJ21-ENG

Copy link
Copy Markdown
Contributor

Explanation of Change

Replaces the July product marketing announcement with the August admin and eligible member variants and their supplied images. The admin CTA uses the selected admin workspace's hydrated accounting connections to route to Vendors when enabled, or safely falls back to More Features while offline or after a failed connection refresh. Members with Custom Agent access can open the new Agents flow without bypassing its beta boundary. Dismissal remains campaign-keyed and is persisted before navigation.

Fixed Issues

$ #98233
PROPOSAL: #98233 (comment)

Tests

  1. Verify that no errors related to ProductMarketingWindow appear in the JS console.
  2. Sign in with a fresh member account that has Custom Agent beta access and is not an admin of any active workspace.
  3. Verify the Pre-built agents for you window appears with the employee image and Dismiss / Try it out actions.
  4. Press Try it out, verify the new Agents page opens, and verify the window is dismissed before navigation and does not reappear after reload.
  5. Remove Custom Agent beta access from the member account and verify the member window is not shown.
  6. Sign in with an admin account whose selected admin workspace does not have Vendors enabled.
  7. Verify the Enhanced vendor mapping window appears with the admin image, then press Try it out and verify the workspace More Features page opens.
  8. Repeat with a workspace that has the Vendor Matching beta and a supported accounting connection configured.
  9. Verify Try it out opens that workspace's Vendors page after its connection data finishes loading.
  10. Make a non-admin workspace active while the account administers another active workspace. Verify the CTA stays disabled while the fallback workspace's connections load, then routes using the fallback admin workspace.
  11. Dismiss the window, reload, and verify the August window stays dismissed. With an account whose last dismissed campaign is July, verify the August window still appears.
  • Verify that no errors related to ProductMarketingWindow appear in the JS console

Offline tests

  1. Use an admin account where the active workspace is not administered but another active workspace is.
  2. Go offline before the fallback workspace's accounting connections are fetched.
  3. Verify the admin CTA remains actionable and opens More Features instead of assuming Vendors is enabled or showing an error.
  4. Restore the network, let the connection data load, and verify the destination follows the workspace's actual Vendors state.

QA Steps

  1. Repeat Tests 1-11 on staging with fresh member and admin accounts, including member accounts with and without Custom Agent beta access.
  2. For the direct Vendors case, use an admin workspace with Vendor Matching beta access and a supported accounting connection.
  3. Verify the fallback More Features destination remains visible and actionable for the intended campaign recipient; enabling Vendors is tracked separately from this PR.
  4. Repeat the Offline tests and verify no incorrect Vendors destination or error page appears.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not recorded yet (draft PR).

Android: mWeb Chrome

Not recorded yet (draft PR).

iOS: Native

Not recorded yet (draft PR).

iOS: mWeb Safari

Not recorded yet (draft PR).

MacOS: Chrome / Safari

Pre-review POC evidence from the earlier candidate. This does not replace final-head, all-platform recordings.

Member marketing window:

Member marketing window

Admin marketing window:

Admin marketing window

More Features fallback:

More Features fallback

Direct Vendors destination:

Direct Vendors destination

Video: https://github.com/user-attachments/assets/e4a0baee-0145-4a50-b94b-653385b1e225

@melvin-bot

melvin-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant