[Commuter Mileage Exclusion] Fix guard modal image overlap - #98571
Open
fedirjh wants to merge 8 commits into
Open
[Commuter Mileage Exclusion] Fix guard modal image overlap#98571fedirjh wants to merge 8 commits into
fedirjh wants to merge 8 commits into
Conversation
fedirjh
marked this pull request as ready for review
August 13, 2026 11:09
melvin-bot
Bot
requested review from
JmillsExpensify and
marufsharifi
and removed request for
a team
August 13, 2026 11:09
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeScreen_Recording_20260813_170307_Chrome.mp4iOS: HybridAppScreen.Recording.2026-08-13.at.5.46.05.PM.moviOS: mWeb SafariScreen.Recording.2026-08-13.at.5.40.29.PM.movMacOS: Chrome / SafariScreen.Recording.2026-08-13.at.4.47.01.PM.mov |
Contributor
Contributor
Author
|
@shawnborton Updated
|
Contributor
|
Awesome, thank you! |
Contributor
|
@fedirjh, could you please take a look at failed actions? thanks. |
Contributor
Author
|
@marufsharifi Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Explanation of Change
The commuter-exclusion guard constrained its illustration wrapper to 160×140, but
ConfirmContentalways rendered the SVG at 220px tall. On Android, the SVG overflowed the wrapper and overlapped the modal title.This adds optional image dimensions to
ConfirmContentandConfirmModal, renders the commuter illustration at its intended 160×140 size, and removes the redundant wrapper style. Existing confirm modals keep the current default dimensions when the new props are omitted.Fixed Issues
$ #98228
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests and Offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari