fix: fix 3 typos and code bugs#13
Open
Avicennasis wants to merge 1 commit into
Open
Conversation
- utils.lua: "Delcaration" → "Declaration" - interpreter.lua: "nill" → "nil" (undefined variable in comparison) - assignment.lua: "this.data" → "self.data" (wrong variable name; `self` is used consistently throughout the file, `this` was likely a JavaScript habit — would crash at runtime as `this` is nil in Lua)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 1 spelling error and 2 code bugs across 3 Lua files:
nill→nil— compares against undefined variablenillinstead of Lua'snilkeyword. Functionally equivalent (undefined variables evaluate to nil in Lua) but confusing and incorrect.this.data[name]→self.data[name]— the file usesselfconsistently (21 occurrences); this singlethisreference is a JavaScript naming habit that would crash at runtime (thisis nil in Lua, causing "attempt to index a nil value").The
nillandthisfixes are behavioral changes — please review carefully.