Fix installation step for MacOS platform#15
Open
yyovil wants to merge 1 commit intoFireRedTeam:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the source-install dependency set to better support Apple Silicon and other CPU-only environments by removing CUDA-specific PyTorch constraints and loosening a problematic wheel pin, with a README note for CUDA users.
Changes:
- Switch
requirements.txtfrom a CUDA-suffixed Torch pin to a platform-neutral PyTorch spec. - Relax the
kaldi_native_fbankversion constraint to allow resolving Apple Silicon-compatible wheels. - Document in the README that CUDA users should install their preferred PyTorch build separately for source installs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements.txt | Replaces CUDA-specific Torch pin with a generic Torch constraint; loosens kaldi_native_fbank pin. |
| README.md | Adds guidance clarifying PyTorch installation expectations for CUDA users on the source-install path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for you PR |
Contributor
|
I'll merge this PR if the code is ready |
2. added the installation step FireRedTeam#3 for macos platform in README.md Entire-Checkpoint: a5a8c0596310
yyovil
force-pushed
the
fix/issue-8-apple-silicon
branch
from
8022ebf to
890f4d0
Compare
yyovil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem faced
torch==2.1.0+cu118requires Nvidia CUDA andkaldi_native_fbanklacks a native macOS arm64 wheel.Before
pip install -r requirements.txtfailed on MacOS platformAfter
FireRedVAD-demo.mp4
pip install -r requirements-macos-arm64.txtresolves the installation error.Closes #8.