Skip to content

fix(update): only suggest IDE restarts when needed - #1656

Open
clay-good wants to merge 2 commits into
mainfrom
codex/fix-update-restart-hint
Open

fix(update): only suggest IDE restarts when needed#1656
clay-good wants to merge 2 commits into
mainfrom
codex/fix-update-restart-hint

Conversation

@clay-good

@clay-good clay-good commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Status: LGTM

What was wrong

openspec init already avoids restart guidance for CLI tools, but openspec update printed “Restart your IDE” after every successful refresh. Claude Code, Codex, Gemini CLI, and other command-line tools therefore received an instruction that could not help them.

How it was fixed

The update summary now shows the existing restart hint only when an IDE-resident tool successfully received commands or skills. The tool metadata and generation rules already used by init remain the source of truth. No command behavior, configuration, generated files, or workflow architecture changed.

Replication / proof

  • Added regression coverage for CLI-only and IDE-only updates, mixed affected/unaffected tools, partial failures, and legacy upgrades.
  • Packaged CLI smoke test: forced Claude Code update omits the hint; forced Cursor update keeps it.
  • pnpm run build
  • pnpm run lint
  • pnpm test -- --maxWorkers=4 --reporter=dot: 3,971 tests passed across 136 files.
  • GitHub CI passed on Linux, macOS, and Windows, plus static analysis, CodeQL, audit, dependency review, and release tracking.

Notes / nits

This is an output-only patch with a patch changeset. It does not change OpenSpec design, schemas, file formats, or user workflows.

Closes #1608

Summary by CodeRabbit

  • Bug Fixes
    • Updated tool-refresh messages to show IDE restart guidance only when applicable.
    • CLI tools such as Claude Code, Codex, and Gemini CLI no longer display unnecessary IDE restart instructions.
    • IDE tools such as Cursor continue to receive restart guidance when required.

@clay-good
clay-good requested a review from a team as a code owner August 14, 2026 19:26
@clay-good
clay-good requested review from TabishB and removed request for a team August 14, 2026 19:26
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1fdac588-1743-4933-8387-d6e74db84ba3

📥 Commits

Reviewing files that changed from the base of the PR and between 3437de8 and 2c64d2b.

📒 Files selected for processing (1)
  • test/core/update.test.ts

📝 Walkthrough

Walkthrough

openspec update now tracks affected tools and displays IDE restart guidance only for tools that require it. Tests cover successful and failed IDE updates, CLI-only updates, unaffected tools, and legacy upgrades. A patch changeset documents the behavior.

Changes

Update restart guidance

Layer / File(s) Summary
Conditional restart logic
src/core/update.ts
The update process records updated tool IDs and shows the restart notice only when an affected tool requires an IDE restart and generates skills or commands.
Restart guidance validation
test/core/update.test.ts, .changeset/quiet-cli-update.md
Tests cover Cursor and Claude updates, failure paths, unaffected IDE tools, and legacy upgrades. The changeset documents the narrowed restart behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2c64d

The update summary now shows IDE restart guidance only when applicable; this is a localized output change with no actionable merge-blocking risk remaining after normal checks.

Possibly related PRs

Suggested reviewers: tabishb, alfred-openspec

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The implementation gates restart guidance by tool requirements and update success, suppressing hints for CLI tools while retaining them for IDE tools [#1608].
Out of Scope Changes check ✅ Passed The changeset, implementation, and regression tests directly support the linked issue and contain no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: showing IDE restart guidance only when required.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-update-restart-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openspec update still shows 'Restart your IDE' hint unconditionally (CLI tools included)

1 participant