fix(skills): avoid activation outside OpenSpec projects - #1658
Open
clay-good wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (26)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughOpenSpec skill descriptions and workflow templates now require an OpenSpec directory, applicable store, or explicit OpenSpec request. A shared activation guard is prepended to generated workflows. Parity tests validate the generated content. ChangesOpenSpec skill activation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change limits automatic skill activation to OpenSpec projects or explicitly named OpenSpec requests while preserving explicit commands and workflow behavior. No actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: LGTM.
What was wrong
Generated OpenSpec skills advertised broad actions such as exploring ideas and proposing features. Tools that discover skills globally could therefore select an OpenSpec workflow for an ordinary request in a repository that does not use OpenSpec.
How it was fixed
Every generated workflow skill now leads with an OpenSpec-only selection boundary. It still supports all existing OpenSpec contexts: a local
openspec/root, a configured or user-selected store, or an explicit skill invocation or OpenSpec request. Each original workflow-specific routing description remains intact.As defense in depth, skill bodies now perform the same check before applying a workflow and return to normal assistance if no OpenSpec context exists. Explicit
/opsx:*commands remain unchanged.Replication / proof
mainemits broad global descriptions for all 12 workflow skills, including explore and propose.Notes / nits
This changes skill-selection metadata and adds a read-only skill preflight. It does not change CLI behavior, command syntax, schemas, file formats, workflow architecture, or explicit slash-command behavior. No changeset is included because routine bug fixes follow the normal release cadence.
Closes #1645
Summary by CodeRabbit
Behavior Updates
Tests